Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws/endpoints: Fix testing bug in partitions other than aws. #2920

Merged
merged 1 commit into from Nov 1, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions aws/endpoints/v3model_test.go
Expand Up @@ -542,6 +542,11 @@ func TestEndpointFor_RegionalFlag(t *testing.T) {
}

func TestEndpointFor_EmptyRegion(t *testing.T) {
// skip this test for partitions outside `aws` partition
if DefaultPartitions()[0].id != "aws" {
t.Skip()
}

cases := map[string]struct {
Service string
Region string
Expand Down