Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix streaming APIs' Err method closing stream #2882

Merged
merged 3 commits into from Oct 21, 2019
Merged

Fix streaming APIs' Err method closing stream #2882

merged 3 commits into from Oct 21, 2019
+183 −38

Commits on Oct 10, 2019

  1. Fix streaming APIs' Err method closing stream 

    Fixes calling the Err method on SDK's Amazon Kinesis's SubscribeToShared
and Amazon S3's SelectObjectContent response EventStream members closing
the stream. This would cause unexpected read errors, or early
termination of the streams. Only the Close method of the streaming
members will close the streams.

Improved generated unit and integration tests for streaming API
operations.

Related to aws#2769
    @jasdel
    jasdel committed Oct 10, 2019
    Copy the full SHA
    24311b0 View commit details
    Browse the repository at this point in the history

  2. add change log

    @jasdel
    jasdel committed Oct 10, 2019
    Copy the full SHA
    7746eb8 View commit details
    Browse the repository at this point in the history

  3. update tests to be compatiable with streaming operations without events

    @jasdel
    jasdel committed Oct 10, 2019
    Copy the full SHA
    108b9a1 View commit details
    Browse the repository at this point in the history