service/dynamodb/dynamodbattribute: Support string type alias for map… #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
force-pushed
the
bug/ddbMapKey
branch
from
1204ad3
to
e396471
Compare
skmcgrail
added
the
needs-review
jasdel
approved these changes
Oct 2, 2019
There was a problem hiding this comment.
Looks good.
For the v2 SDK we may want to consider support for other comparable types such as bool, float, int and other scalars. We have received request in the past to support integer map key unmarshal support, (e.g. map[int]string), https://blog.golang.org/go-maps-in-action#TOC_5.
I've cut aws/aws-sdk-go-v2#411 to track this conversation separately and use it for additional follow-up. |
skmcgrail
removed
the
needs-review
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a panic that could occur during decode if a map type contained a string type alias for it's key.
Fixes #2868