Skip to content

Commit

Permalink
aws/endpoints: Fix testing bug in partitions other than aws (#2920)
Browse files Browse the repository at this point in the history
TestEndpointFor_EmptyRegion breaks due to an unknown service called by the test. The fix runs this test only for aws partitions, and skips others.
  • Loading branch information
skotambkar authored and jasdel committed Nov 1, 2019
1 parent a5b47f9 commit 11c6b64
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions aws/endpoints/v3model_test.go
Expand Up @@ -542,6 +542,11 @@ func TestEndpointFor_RegionalFlag(t *testing.T) {
}

func TestEndpointFor_EmptyRegion(t *testing.T) {
// skip this test for partitions outside `aws` partition
if DefaultPartitions()[0].id != "aws" {
t.Skip()
}

cases := map[string]struct {
Service string
Region string
Expand Down

0 comments on commit 11c6b64

Please sign in to comment.