aws/endpoints: Fix SDK resolving endpoint without region #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
approved these changes
Oct 26, 2019
Fixes the SDK's endpoint resolve incorrectly resolving endpoints for a service when the region is empty. Also fixes the SDK attempting to resolve a service when the service value is empty. Related to: aws/aws-sdk-go#2911
jasdel
force-pushed
the
fixup/EmptyRegion
branch
from
5f3864f
to
46d8b3f
Compare
skotambkar
reviewed
Dec 11, 2019
skotambkar
reviewed
Dec 11, 2019
skotambkar
approved these changes
Dec 11, 2019
skotambkar
approved these changes
Dec 12, 2019
skotambkar
added a commit
that referenced
this pull request
Dec 12, 2019
=== Services --- * Synced the V2 SDK with latest AWS service API definitions. SDK Bugs --- * `aws/endpoints`: aws/endpoints: Fix SDK resolving endpoint without region ([#420](#420)) * Fixes the SDK's endpoint resolve incorrectly resolving endpoints for a service when the region is empty. Also fixes the SDK attempting to resolve a service when the service value is empty. * Related to [aws/aws-sdk-go#2909](aws/aws-sdk-go#2909)
skotambkar
added a commit
that referenced
this pull request
Dec 12, 2019
=== Services --- * Synced the V2 SDK with latest AWS service API definitions. SDK Bugs --- * `aws/endpoints`: aws/endpoints: Fix SDK resolving endpoint without region ([#420](#420)) * Fixes the SDK's endpoint resolve incorrectly resolving endpoints for a service when the region is empty. Also fixes the SDK attempting to resolve a service when the service value is empty. * Related to [aws/aws-sdk-go#2909](aws/aws-sdk-go#2909)
skotambkar
added a commit
that referenced
this pull request
Dec 12, 2019
* Release v0.18.0 (2019-12-12) === Services --- * Synced the V2 SDK with latest AWS service API definitions. SDK Bugs --- * `aws/endpoints`: aws/endpoints: Fix SDK resolving endpoint without region ([#420](#420)) * Fixes the SDK's endpoint resolve incorrectly resolving endpoints for a service when the region is empty. Also fixes the SDK attempting to resolve a service when the service value is empty. * Related to [aws/aws-sdk-go#2909](aws/aws-sdk-go#2909)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the SDK's endpoint resolve incorrectly resolving endpoints for a service when the region is empty. Also fixes the SDK attempting to resolve a service when the service value is empty.
Related to: aws/aws-sdk-go#2911