Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: Fix EventSteam deserializer generation bug #1638

Merged
merged 3 commits into from Mar 23, 2022
Merged

codegen: Fix EventSteam deserializer generation bug #1638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85d2a13
codegen: Fix EventSteam deserializer generation bug
skmcgrail Mar 22, 2022
29f0a83
codegen: Namespace event stream writer and reader implementations
skmcgrail Mar 23, 2022
93bba0b
Regnerated Clients
skmcgrail Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
803 changes: 403 additions & 400 deletions ...s-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AwsEventStreamUtils.java
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 4 additions & 3 deletions ...codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonRpcProtocolGenerator.java
View file
Open in desktop
Expand Up @@ -203,7 +203,8 @@ public void generateEventStreamComponents(GenerationContext context) {

@Override
protected void writeOperationSerializerMiddlewareEventStreamSetup(GenerationContext context, EventStreamInfo info) {
AwsEventStreamUtils.writeOperationSerializerMiddlewareEventStreamSetup(context, info);
AwsEventStreamUtils.writeOperationSerializerMiddlewareEventStreamSetup(context, info,
"httpBindingEncoder");
}

@Override
Expand Down Expand Up @@ -315,7 +316,7 @@ protected void generateEventStreamDeserializers(
payloadTarget, ctx.getService(), getProtocolName());
var ctxWriter = ctx.getWriter().get();
ctxWriter.openBlock("if err := $L(&$L, shape); err != nil {", "}", functionName, operand,
() -> handleDecodeError(ctxWriter))
() -> handleDecodeError(ctxWriter))
.write("return nil");
});

Expand Down Expand Up @@ -348,7 +349,7 @@ protected void generateEventStreamDeserializers(
AwsProtocolUtils.initializeJsonEventMessageDeserializer(ctx, "nil,");
var ctxWriter = ctx.getWriter().get();
ctxWriter.openBlock("if err := $L(&$L, shape); err != nil {", "}", functionName, operand,
() -> handleDecodeError(ctxWriter, "nil,"))
() -> handleDecodeError(ctxWriter, "nil,"))
.write("return v, nil");
});
var initialMessageMembers = streamInfo.getInitialMessageMembers()
Expand Down
2 changes: 1 addition & 1 deletion ...odegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
View file
Open in desktop
Expand Up @@ -519,7 +519,7 @@ public void generateEventStreamComponents(GenerationContext context) {

@Override
protected void writeOperationSerializerMiddlewareEventStreamSetup(GenerationContext context, EventStreamInfo info) {
AwsEventStreamUtils.writeOperationSerializerMiddlewareEventStreamSetup(context, info);
AwsEventStreamUtils.writeOperationSerializerMiddlewareEventStreamSetup(context, info, "restEncoder");
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion ...codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestXmlProtocolGenerator.java
View file
Open in desktop
Expand Up @@ -475,7 +475,7 @@ public void generateEventStreamComponents(GenerationContext context) {

@Override
protected void writeOperationSerializerMiddlewareEventStreamSetup(GenerationContext context, EventStreamInfo info) {
AwsEventStreamUtils.writeOperationSerializerMiddlewareEventStreamSetup(context, info);
AwsEventStreamUtils.writeOperationSerializerMiddlewareEventStreamSetup(context, info, "restEncoder");
}

@Override
Expand Down
24 changes: 12 additions & 12 deletions service/kinesis/eventstream.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

54 changes: 27 additions & 27 deletions service/lexruntimev2/eventstream.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.