Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded destructive integration tests for Amazon S3 Control API #1637

Merged
merged 1 commit into from Mar 23, 2022
Merged

Remove unneeded destructive integration tests for Amazon S3 Control API #1637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 1 addition & 17 deletions service/internal/integrationtest/s3control/api_test.go
View file
Open in desktop
Expand Up @@ -19,26 +19,10 @@ func TestInteg_PublicAccessBlock(t *testing.T) {
AccountId: aws.String(accountID),
})
if err != nil {
// Ignore NoSuchPublicAccessBlockConfiguration, but fail on any other error.
var e *types.NoSuchPublicAccessBlockConfiguration
if !errors.As(err, &e) {
t.Fatalf("expect no error for GetPublicAccessBlock, got %v", err)
}
}

_, err = svc.PutPublicAccessBlock(ctx, &s3control.PutPublicAccessBlockInput{
AccountId: aws.String(accountID),
PublicAccessBlockConfiguration: &types.PublicAccessBlockConfiguration{
IgnorePublicAcls: true,
},
})
if err != nil {
t.Fatalf("expect no error, got %v", err)
}

_, err = svc.DeletePublicAccessBlock(ctx, &s3control.DeletePublicAccessBlockInput{
AccountId: aws.String(accountID),
})
if err != nil {
t.Fatalf("expect no error, got %v", err)
}
}