Add json Unmarshal for AWSEpochTime #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
force-pushed
the
aws_epoch_time_unmarshal
branch
from
4415b1a
to
3c19992
Compare
jasdel
approved these changes
Jun 17, 2021
There was a problem hiding this comment.
Thanks for creating this PR @iliacimpoes. The change looks good. We'll get this merged in and included in our next release.
jrichard8
pushed a commit
to jrichard8/aws-sdk-go-v2
that referenced
this pull request
Feb 14, 2022
Adds UnmarshalJSON for AWSEpochTime to correctly unmarshal AWSEpochTime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
UnmarshalJSONforAWSEpochTime.I wanted to use sign.Policy for testing purposes, to validate generated policy. But AWSEpochTime is not unmarshaled correctly.