service/ec2: Fix generation of number and bool struct members to be pointers #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
approved these changes
Mar 26, 2021
This was referenced Apr 11, 2021
skotambkar
reviewed
May 5, 2021
.changes/next-release/service.ec2-bugfix-1616785668377831000.json
Outdated
Show resolved
Hide resolved
skotambkar
approved these changes
May 5, 2021
Adds a backfill customization to the Amazon EC2 API model so that all unboxed number and boolean shapes are correctly decorated as boxed. The API does not handle unboxed members. This causes the API client generated from the model to be unusable in many cases. The generated API client will contain breaking changes, but these breaking changes are here to fix the API client that was unusable in many ways.
This was referenced May 7, 2021
jrichard8
pushed a commit
to jrichard8/aws-sdk-go-v2
that referenced
this pull request
Feb 14, 2022
…ointers (aws#1195) Adds a backfill customization to the Amazon EC2 API model so that all unboxed number and boolean shapes are correctly decorated as boxed. The API does not handle unboxed members. This causes the API client generated from the model to be unusable in many cases. The generated API client will contain breaking changes, but these breaking changes are here to fix the API client that was unusable in many ways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrectly modeled Amazon EC2 number and boolean members in structures. The Amazon EC2 API client has been updated with a breaking change to fix all structure number and boolean members to be pointer types instead of value types.
Fixes #1107, #1178, and #1190. This breaking change is made within the major version of the client' module, because the client's current operations are not usable with value type number and boolean members. The API's behavior requires parameters to be nullable. This translates to the AWS SDK for Go client as the members being pointer types.
The client's behavior could not be reliability patched without a breaking change due to the scope the parameters were used in and server side handling of the parameters.