Skip to content

Commit

Permalink
codegen: Fix EventSteam code generation bug (#1638)
Browse files Browse the repository at this point in the history
* codegen: Fix EventSteam deserializer generation bug
* codegen: Namespace event stream writer and reader implementations
* Regnerated Clients
  • Loading branch information
skmcgrail committed Mar 23, 2022
1 parent 5399c50 commit cd1c8a3
Show file tree
Hide file tree
Showing 8 changed files with 500 additions and 496 deletions.

Large diffs are not rendered by default.

Expand Up @@ -203,7 +203,8 @@ public void generateEventStreamComponents(GenerationContext context) {

@Override
protected void writeOperationSerializerMiddlewareEventStreamSetup(GenerationContext context, EventStreamInfo info) {
AwsEventStreamUtils.writeOperationSerializerMiddlewareEventStreamSetup(context, info);
AwsEventStreamUtils.writeOperationSerializerMiddlewareEventStreamSetup(context, info,
"httpBindingEncoder");
}

@Override
Expand Down Expand Up @@ -315,7 +316,7 @@ protected void generateEventStreamDeserializers(
payloadTarget, ctx.getService(), getProtocolName());
var ctxWriter = ctx.getWriter().get();
ctxWriter.openBlock("if err := $L(&$L, shape); err != nil {", "}", functionName, operand,
() -> handleDecodeError(ctxWriter))
() -> handleDecodeError(ctxWriter))
.write("return nil");
});

Expand Down Expand Up @@ -348,7 +349,7 @@ protected void generateEventStreamDeserializers(
AwsProtocolUtils.initializeJsonEventMessageDeserializer(ctx, "nil,");
var ctxWriter = ctx.getWriter().get();
ctxWriter.openBlock("if err := $L(&$L, shape); err != nil {", "}", functionName, operand,
() -> handleDecodeError(ctxWriter, "nil,"))
() -> handleDecodeError(ctxWriter, "nil,"))
.write("return v, nil");
});
var initialMessageMembers = streamInfo.getInitialMessageMembers()
Expand Down
Expand Up @@ -519,7 +519,7 @@ public void generateEventStreamComponents(GenerationContext context) {

@Override
protected void writeOperationSerializerMiddlewareEventStreamSetup(GenerationContext context, EventStreamInfo info) {
AwsEventStreamUtils.writeOperationSerializerMiddlewareEventStreamSetup(context, info);
AwsEventStreamUtils.writeOperationSerializerMiddlewareEventStreamSetup(context, info, "restEncoder");
}

@Override
Expand Down
Expand Up @@ -475,7 +475,7 @@ public void generateEventStreamComponents(GenerationContext context) {

@Override
protected void writeOperationSerializerMiddlewareEventStreamSetup(GenerationContext context, EventStreamInfo info) {
AwsEventStreamUtils.writeOperationSerializerMiddlewareEventStreamSetup(context, info);
AwsEventStreamUtils.writeOperationSerializerMiddlewareEventStreamSetup(context, info, "restEncoder");
}

@Override
Expand Down
24 changes: 12 additions & 12 deletions service/kinesis/eventstream.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

54 changes: 27 additions & 27 deletions service/lexruntimev2/eventstream.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit cd1c8a3

Please sign in to comment.