fix: Added CR LF to LF Conversion for gradlew #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this documented behavior? |
git config --global core.autocrlf true The Windows git installer also prompts the users during installation on how newlines should be handled. The default is commit with \n and pull with \r\n. |
CoshUS
force-pushed
the
fix/windows-init-line-ending
branch
from
ff589d8
to
3e869cd
Compare
|
excellent, thanks for fixing this. |
hoffa
reviewed
Mar 22, 2021
hoffa
reviewed
Mar 22, 2021
CoshUS
changed the title
sriram-mv
previously requested changes
Mar 22, 2021
hoffa
approved these changes
Mar 24, 2021
moelasmar
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#2551
Why is this change necessary?
SAM CLI quick start Java gradle projects fail to build on Windows with --use-container or with image type.
Windows git clone will change gradlew line endings to \r\n which will not be recognized by Unix sh.
How does it address the issue?
Replace all \r\n in gradlew to \n after cookiecutter.
Simply replacing when the repo is cloned will not work as cookiecutter also changes line endings.
What side effects does this change have?
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.