Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade nx to 14.8.4 #191

Merged
merged 1 commit into from Oct 13, 2022
Merged

chore: upgrade nx to 14.8.4 #191

merged 1 commit into from Oct 13, 2022

Conversation

cogwirrel
Copy link
Member

@nx-cloud
Copy link

nx-cloud bot commented Oct 12, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c54f0ee. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link
Contributor

@mteichtahl mteichtahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice quick and simple ver bump.

@martenpayne
Copy link
Contributor

👍 looks good

@JeremyJonas
Copy link
Contributor

@cogwirrel Given these files are managed by projen, shouldn't this be defined in PDKMonorepoProject project file?

Either via devDeps or resolveDependencies...

  1. PDKMonorepoProject devDeps
  2. PDKMonorepoProject resolveDependendencies

@cogwirrel
Copy link
Member Author

@cogwirrel Given these files are managed by projen, shouldn't this be defined in PDKMonorepoProject project file?

Either via devDeps or resolveDependencies...

  1. PDKMonorepoProject devDeps
  2. PDKMonorepoProject resolveDependendencies

The specific versions don't need to be hardcoded in the .projenrc :) https://projen.io/node.html#dependencies

Any dependencies without specific version ranges set (such as react or react@*) will given a version range in package.json so that future package upgrades and changes to the generated lockfiles such as package-lock.json or yarn.lock will follow semver.

Basically if you don't hardcode a version in projenrc you're then free to use other tooling like dependabot or npm-check-updates etc for managing your dependency versions via the package.json :)

I actually used some of the steps from the built in upgrade-deps task from the monorepo project to upgrade these dependencies (npx projen upgrade-deps). Though in this case I just wanted to target the nx deps specifically so ran npx npm-check-updates --deep --rejectVersion 0.0.0 -u "@nrwl/*" "nx" :)

@cogwirrel cogwirrel merged commit 00b84ef into mainline Oct 13, 2022
@cogwirrel cogwirrel deleted the chore/upgrade-nx-14-8-4 branch October 13, 2022 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants