Add HandlerFunc generics support #477
Conversation
Codecov Report
@@ Coverage Diff @@
## main #477 +/- ##
=======================================
Coverage 71.18% 71.18%
=======================================
Files 21 21
Lines 1253 1253
=======================================
Hits 892 892
Misses 295 295
Partials 66 66
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -21,7 +21,7 @@ func TestStartHandlerFunc(t *testing.T) { | |||
| } | |||
|
|
|||
| f := func(context.Context, any) (any, error) { return 1, nil } | |||
| StartHandlerFunc(f) | |||
| StartHandlerFunc[any, any](f) | |||
There was a problem hiding this comment.
this is a breaking change, as the go compiler isn't smart enough to infer the types when more than one variant is added to the interface. See prior discussion: #468 (comment)
There was a problem hiding this comment.
I see, thank you for considering this @bmoffatt !
I am still wondering if we can add this changes by adding another function (let's say StartTypedHandlerFunc for now)that accepts "any" type and it calls StartHandlerFunc[any, any](f).
There will be no type-safe though, but user does not need to specify types for StartHandlerFunc . instead, they may want to use new StartHandlerTypedFunc that supports generics with type parameter.
Sorry my English is not good enough to explain this, hope it works!
bmoffatt
added
breaking change / v2
|
Not merging this one, the requirement to specify the in/out types breaks existing users. |
Description of changes:
Add generics for
HandlerFuncinterface for type-safeStartHandlerFuncBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.