Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamodb: add alternative to Integer conversion helper, Int64, that does not silently cast float values #459

Merged
merged 1 commit into from Jul 27, 2022

Conversation

bmoffatt
Copy link
Collaborator

Issue #, if available:

#454

Description of changes:

Same as Integer(), but without the "convenience" of falling back to float parsing.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #459 (46ca97c) into main (6796528) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
+ Coverage   72.90%   72.97%   +0.07%     
==========================================
  Files          19       19              
  Lines        1085     1088       +3     
==========================================
+ Hits          791      794       +3     
  Misses        225      225              
  Partials       69       69              
Impacted Files Coverage Δ
events/attributevalue.go 78.46% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6796528...46ca97c. Read the comment docs.

@bmoffatt bmoffatt marked this pull request as ready for review July 26, 2022 21:50
@bmoffatt bmoffatt requested a review from carlzogh July 26, 2022 21:50
@bmoffatt bmoffatt merged commit d8bb932 into aws:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants