Add WithEnableSIGTERM option #457
Conversation
…interface emulator
Codecov Report
@@ Coverage Diff @@
## main #457 +/- ##
==========================================
- Coverage 72.90% 69.69% -3.22%
==========================================
Files 19 20 +1
Lines 1085 1201 +116
==========================================
+ Hits 791 837 +46
- Misses 225 297 +72
+ Partials 69 67 -2
Continue to review full report at Codecov.
|
.github/workflows/tests.yml
Outdated
| @@ -25,11 +25,15 @@ jobs: | |||
|
|
|||
| - run: go version | |||
|
|
|||
| - name: install lambda runtime interface emulator | |||
| run: curl -L -o /usr/local/bin/aws-lambda-rie https://github.com/aws/aws-lambda-runtime-interface-emulator/releases/download/v1.6/aws-lambda-rie-x86_64 | |||
There was a problem hiding this comment.
change v1.6 to latest in order to always test against the most recent release - eg. URL from RIE readme:
https://github.com/aws/aws-lambda-runtime-interface-emulator/releases/latest/download/aws-lambda-rie-x86_64
There was a problem hiding this comment.
$ curl -L https://github.com/aws/aws-lambda-runtime-interface-emulator/releases/download/latest/aws-lambda-rie-x86_64
Not Found
There was a problem hiding this comment.
Oh oops no arch suffix for x86_64 apparently
https://github.com/aws/aws-lambda-runtime-interface-emulator/releases/latest/download/aws-lambda-rie
There was a problem hiding this comment.
Actually it seems to be a different url ordering for latest
blahblah/latest/download/
Not
blahblah/download/latest/
🤷♂️
Issue #, if available:
#318
Description of changes:
Adds an incomplete internal implementation of the extensions API, and uses it to add an option to opt-in to SIGTERM. This allows function authors to run code on shutdown without also having to attach an extension layer.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.