feat(codebuild): add missing types for webhook filters #30204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
beginning-contributor
github-actions
bot
added
effort/small
aseppala
force-pushed
the
integ-test-codebuild-workflow-job-queued
branch
from
654e648
to
d3c43f2
Compare
aws-cdk-automation
added
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aseppala
commented
May 21, 2024
| super(scope, id); | ||
|
|
||
| const source = codebuild.Source.gitHub({ | ||
| owner: 'aws', |
There was a problem hiding this comment.
Would it actually make sense to allow overriding this value to personal fork using an env var (which?) so that non cdk maintainers can run this test?
|
Any ETA for when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #30062.
Reason for this change
Extends #30064 and adds the requested integration test.
Description of changes
Adds an integration test to test WORKFLOW_JOB_QUEUED GitHub event for a AWS CodeBuild project.
Description of how you validated changes
As I can't authorize my AWS account to create webhooks on
aws/aws-cdkGithub repository I've executed the new integration test using my own fork ofaws/aws-cdkas the source and verified that the test passes. I've then modified the files and patched them to useaws/aws-cdkas the source.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license