New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update aws service spec in a separate job #26531
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| name: AWS Service Spec Update | ||
|
|
||
| on: | ||
| schedule: | ||
| # Every Monday at 13:37 UTC | ||
| - cron: 37 13 * * 1 | ||
| workflow_dispatch: {} | ||
|
|
||
| jobs: | ||
| update-spec: | ||
| name: Update AWS Service Spec packages | ||
| permissions: | ||
| contents: read | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
|
|
||
| - name: Check Out | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Set up Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: "*" | ||
| env: | ||
| NODE_OPTIONS: "--max-old-space-size=8196 --experimental-worker ${NODE_OPTIONS:-}" | ||
|
|
||
| - name: Yarn Install | ||
| run: yarn install --frozen-lockfile | ||
| - name: Install ncu tool | ||
| run: npm -g install lerna npm-check-updates | ||
| - name: Run "ncu" for service spec packages | ||
| run: lerna exec --parallel ncu -- --upgrade --filter='@aws-cdk/aws-service-spec,@aws-cdk/service-spec-types' --target=latest | ||
|
|
||
| # This will ensure the current lockfile is up-to-date with the dependency specifications | ||
| - name: Install latest version & update lockfile | ||
| run: |- | ||
| yarn upgrade @aws-cdk/aws-service-spec @aws-cdk/service-spec-types | ||
| # Next, create and upload the changes as a patch file. This will later be downloaded to create a pull request | ||
| # Creating a pull request requires write permissions and it's best to keep write privileges isolated. | ||
| - name: Create Patch | ||
| run: |- | ||
| git add . | ||
| git diff --patch --staged > ${{ runner.temp }}/update-spec.patch | ||
| - name: Upload Patch | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: update-spec.patch | ||
| path: ${{ runner.temp }}/update-spec.patch | ||
|
|
||
| pr: | ||
| name: Create Pull Request | ||
| needs: update-spec | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check Out | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Download patch | ||
| uses: actions/download-artifact@v3 | ||
| with: | ||
| name: update-spec.patch | ||
| path: ${{ runner.temp }} | ||
|
|
||
| - name: Apply patch | ||
| run: '[ -s ${{ runner.temp }}/update-spec.patch ] && git apply ${{ runner.temp }}/update-spec.patch || echo "Empty patch. Skipping."' | ||
|
|
||
| - name: Make Pull Request | ||
| uses: peter-evans/create-pull-request@v5 | ||
| with: | ||
| # Git commit details | ||
| branch: automation/spec-update | ||
| author: aws-cdk-automation <aws-cdk-automation@users.noreply.github.com> | ||
| commit-message: |- | ||
| feat: update AWS Service Spec | ||
| AWS Service Spec packages to latest versions. | ||
| # Pull Request details | ||
| title: 'feat: update AWS Service Spec' | ||
| body: |- | ||
| AWS Service Spec packages to latest versions. | ||
| labels: contribution/core,dependencies,auto-approve | ||
| team-reviewers: aws-cdk-team | ||
| # Github prevents further Github actions to be run if the default Github token is used. | ||
| # Instead use a privileged token here, so further GH actions can be triggered on this PR. | ||
| token: ${{ secrets.PROJEN_GITHUB_TOKEN }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Special case notice was:
The linked PR has now been published and we have already upgraded lerna manually beyond it.
The patch is long gone as well.