Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appsync): unexpected resolver replacement #23322

Merged
merged 3 commits into from Dec 14, 2022
Merged

Commits on Dec 13, 2022

  1. fix(appsync): unstable IDs on resolvers and functions

    Fixes an issue that would cause unexpected resource replacement for
    appsync resolvers and functions because of construct nesting and ID
    generation.
    
    Changes `createResolver` and `createFunction` methods on `GraphQlApi`
    and `DataSource` constructs to require explicitly passing an ID.
    Additionally changes the scope of the constructs created in
    `createResolver` and `createFunction` on the `DataSource` construct to
    be `this.api` instead of `this`. This allows users to change the data
    sources of resolvers and functions while keeping the IDs stable and
    avoiding resource replacement.
    
    This helps to avoid the `only one resolver per field` error that occurs
    when deleting a resolver on a field, and adding a new one within the
    same deployment.
    
    BREAKING CHANGE: `DataSource.createResolver`,
    `DataSource.createFunction`, and `GraphQlApi.createResolver` now require
    2 arguments instead of 1.
    
    Fixes: #13269
    MrArnoldPalmer committed Dec 13, 2022
    Copy the full SHA
    da3d9bf View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. fix examples

    MrArnoldPalmer committed Dec 14, 2022
    Copy the full SHA
    d569c7f View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    4686e93 View commit details
    Browse the repository at this point in the history