Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(s3-deployment): add additional sources with addSource #23321

Merged
merged 2 commits into from Dec 14, 2022
Merged

feat(s3-deployment): add additional sources with addSource #23321

merged 2 commits into from Dec 14, 2022

Commits on Dec 12, 2022

  1. feat(s3-deployment): add additional sources with addSource 

    PR #22857 is introducing a use case where we need to be able to add
additional sources after the `BucketDeployment` resource is created.

This PR adds an `addSource` method and changes all the sources
evaluation within the construct to be lazy.
    @corymhall
    corymhall committed Dec 12, 2022
    Copy the full SHA
    64a60d2 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Merge branch 'main' into corymhall/s3-deployment/addSource

    @mergify
    mergify[bot] committed Dec 14, 2022
    Copy the full SHA
    3be742a View commit details
    Browse the repository at this point in the history