Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): typescript init templates fail with error in build step #23129

Closed
wants to merge 1 commit into from
Closed

fix(cli): typescript init templates fail with error in build step #23129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/yarn-upgrade.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
lerna exec --parallel ncu -- --upgrade --reject='@types/node,@types/prettier,@types/fs-extra,constructs,typescript,aws-sdk,aws-sdk-mock,${{ steps.list-packages.outputs.list }}' --target=minor
# Upgrade package.jsons in init templates
for pj in $(find packages/aws-cdk/lib/init-templates -name package.json); do
(cd $(dirname $pj) && ncu --upgrade --reject='@types/node,@types/prettier,@types/fs-extra,constructs,typescript,aws-sdk,aws-sdk-mock,ts-jest,jest,${{ steps.list-packages.outputs.list }}')
(cd $(dirname $pj) && ncu --upgrade --reject='@types/babel__traverse,@types/node,@types/prettier,@types/fs-extra,constructs,typescript,aws-sdk,aws-sdk-mock,ts-jest,jest,${{ steps.list-packages.outputs.list }}')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this workflow is used at all.
The Yarn Upgrade v1-main workflow on main doesn't upgrade the packages in the templates (probably for the best).

done
# Upgrade dependencies at an aws-eks integ test docker image
cd packages/@aws-cdk/aws-eks/test/sdk-call-integ-test-docker-app/app/ && ncu --upgrade --reject='@types/jest,@types/node,@types/prettier,@types/fs-extra,constructs,typescript,aws-sdk,aws-sdk-mock,ts-jest,jest,${{ steps.list-packages.outputs.list }}'
Expand Down
1 change: 1 addition & 0 deletions packages/aws-cdk/lib/init-templates/v1/app/typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
},
"devDependencies": {
"@aws-cdk/assertions": "%cdk-version%",
"@types/babel__traverse": "7.18.2",
"@types/prettier": "2.6.0",
"@types/jest": "^27.5.0",
"@types/node": "10.17.27",
Expand Down
1 change: 1 addition & 0 deletions packages/aws-cdk/lib/init-templates/v1/lib/typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
},
"devDependencies": {
"@aws-cdk/assertions": "%cdk-version%",
"@types/babel__traverse": "7.18.2",
"@types/jest": "^27.5.0",
"@types/prettier": "2.6.0",
"@types/node": "10.17.27",
Expand Down
1 change: 1 addition & 0 deletions packages/aws-cdk/lib/init-templates/v1/sample-app/typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"devDependencies": {
"aws-cdk": "%cdk-version%",
"@aws-cdk/assertions": "%cdk-version%",
"@types/babel__traverse": "7.18.2",
"@types/jest": "^27.5.0",
"@types/node": "10.17.27",
"@types/prettier": "2.6.0",
Expand Down
1 change: 1 addition & 0 deletions packages/aws-cdk/lib/init-templates/v2/app/typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"cdk": "cdk"
},
"devDependencies": {
"@types/babel__traverse": "7.18.2",
"@types/jest": "^27.5.0",
"@types/node": "10.17.27",
"@types/prettier": "2.6.0",
Expand Down
1 change: 1 addition & 0 deletions packages/aws-cdk/lib/init-templates/v2/lib/typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"test": "jest"
},
"devDependencies": {
"@types/babel__traverse": "7.18.2",
"@types/jest": "^27.5.0",
"@types/node": "10.17.27",
"@types/prettier": "2.6.0",
Expand Down
1 change: 1 addition & 0 deletions packages/aws-cdk/lib/init-templates/v2/sample-app/typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"cdk": "cdk"
},
"devDependencies": {
"@types/babel__traverse": "7.18.2",
"aws-cdk": "%cdk-version%",
"@types/jest": "^27.5.0",
"@types/node": "10.17.27",
Expand Down