Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codedeploy): CodeDeploy deployment construct for ECS - SUPERSEDED by #22455 #22454

Closed
wants to merge 8 commits into from

Conversation

cplee
Copy link
Contributor

@cplee cplee commented Oct 11, 2022


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 11, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team October 11, 2022 06:51
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Oct 11, 2022
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@cplee cplee changed the title feat(codedeploy: CodeDeploy deployment construct for ECS feat(codedeploy): CodeDeploy deployment construct for ECS Oct 11, 2022
@cplee cplee force-pushed the ecs-deployment branch 2 times, most recently from b907660 to 3ed2861 Compare October 11, 2022 07:14
@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2022

⚠️ The sha of the head commit of this PR conflicts with #22455. Mergify cannot evaluate rules on this PR. ⚠️

@cplee cplee changed the title feat(codedeploy): CodeDeploy deployment construct for ECS feat(codedeploy): CodeDeploy deployment construct for ECS - SUPERSEDED by #22455 Oct 11, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 76e04c1
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants