Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipelines): policy size too large at around ~70 actions #20189

Closed
wants to merge 20 commits into from

Commits on May 3, 2022

  1. fix(pipelines): policy size too large at around ~70 actions

    Two changes:
    
    - Collapse CodeBuild action Roles: each CodeBuild step used to create a
      fresh Role to run the CodeBuild action. Change to use one Role for all
      CodeBuild actions. This saves a lot of resources and policy space when
      using a lot of CodeBuild steps, and doesn't appreciably change the
      security posture of the Pipeline (note: this is *not* about the
      Execution Role of the CodeBuild projects, this is about the Role
      assumed by the Pipeline to initiate execution of the Project).
    - If inline policies grow bigger than 10k, split additional statements
      off into ManagedPolicies.
    
    Since we want to do the splitting post-merging (to get the most bang for
    our buck), we now need to do statement merging during the `prepare`
    phase (that is, pre-rendering, instead of post-rendering). That means it
    had to be modified to work on `PolicyStatement` objects, instead of on
    raw IAM JSON documents.
    
    Closes #19276, closes #19939, closes #19835.
    rix0rrr committed May 3, 2022
    Configuration menu
    Copy the full SHA
    fbdd9e8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    39da03d View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. Fix sorting

    rix0rrr committed May 4, 2022
    Configuration menu
    Copy the full SHA
    c6bd392 View commit details
    Browse the repository at this point in the history
  2. Fix sorting

    rix0rrr committed May 4, 2022
    Configuration menu
    Copy the full SHA
    bc35fd1 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. Configuration menu
    Copy the full SHA
    d8d24de View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    145b66d View commit details
    Browse the repository at this point in the history
  3. Sort principals properly

    rix0rrr committed May 5, 2022
    Configuration menu
    Copy the full SHA
    da17422 View commit details
    Browse the repository at this point in the history
  4. Update docstring

    rix0rrr committed May 5, 2022
    Configuration menu
    Copy the full SHA
    c7db65c View commit details
    Browse the repository at this point in the history

Commits on May 12, 2022

  1. Configuration menu
    Copy the full SHA
    a32e3b8 View commit details
    Browse the repository at this point in the history
  2. Fix KMS key impl

    rix0rrr committed May 12, 2022
    Configuration menu
    Copy the full SHA
    39f4af2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    930d612 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2022

  1. Configuration menu
    Copy the full SHA
    e5e5922 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. Configuration menu
    Copy the full SHA
    37b4c57 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    65aaf02 View commit details
    Browse the repository at this point in the history
  3. Update snapshots

    rix0rrr committed May 16, 2022
    Configuration menu
    Copy the full SHA
    0a30ed6 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Update snapshots

    rix0rrr committed May 17, 2022
    Configuration menu
    Copy the full SHA
    6229594 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    424736b View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. Configuration menu
    Copy the full SHA
    3a06e41 View commit details
    Browse the repository at this point in the history
  2. Rewrite test

    rix0rrr committed May 18, 2022
    Configuration menu
    Copy the full SHA
    0731d6f View commit details
    Browse the repository at this point in the history
  3. Update snaphots

    rix0rrr committed May 18, 2022
    Configuration menu
    Copy the full SHA
    276220f View commit details
    Browse the repository at this point in the history