Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(iam): explain restrictions on addCondition #20165

Merged
merged 3 commits into from May 3, 2022
Merged

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented May 2, 2022

Multiple calls to addCondition aren't as smart as one might want. Clarify that they aren't.

Fixes #20158.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Multiple calls to `addCondition` aren't as smart as one might want. Clarify that they aren't.

Fixes #20158.
@rix0rrr rix0rrr requested a review from a team May 2, 2022 08:47
@rix0rrr rix0rrr self-assigned this May 2, 2022
@gitpod-io
Copy link

gitpod-io bot commented May 2, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team May 2, 2022 08:47
@github-actions github-actions bot added bug This issue is a bug. p2 labels May 2, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 2, 2022
@mergify
Copy link
Contributor

mergify bot commented May 3, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: fa3ac75
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 3, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4fe6717 into master May 3, 2022
@mergify mergify bot deleted the rix0rrr-patch-2 branch May 3, 2022 09:43
wphilipw pushed a commit to wphilipw/aws-cdk that referenced this pull request May 23, 2022
Multiple calls to `addCondition` aren't as smart as one might want. Clarify that they aren't.

Fixes aws#20158.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IAM: addCondition overwrites previous conditions
3 participants