Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apigateway): StepFunctionsIntegration does not create required role and responses #19486

Merged
merged 3 commits into from Mar 21, 2022
Merged

fix(apigateway): StepFunctionsIntegration does not create required role and responses #19486

merged 3 commits into from Mar 21, 2022

Commits on Mar 21, 2022

  1. fix(apigateway): missing rmethod responses and role in Step Functions… 

    … integration

The method responses and role were only automatically created when using
the `StepFunctionsRestApi` construct. Move the logic inside the
the integration.

It's now possible to do:

```ts
api.root.addResource('sfn').addMethod('POST', StepFunctionsIntegration.startExecution(stateMachine));
```

Previously this did not create the proper method responses and required
a role to be passed.
    @jogold
    jogold committed Mar 21, 2022
    Copy the full SHA
    10771f8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into apigw-sfn-method

    @jogold
    jogold committed Mar 21, 2022
    Copy the full SHA
    37e694d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into apigw-sfn-method

    @mergify
    mergify[bot] committed Mar 21, 2022
    Copy the full SHA
    05c2b67 View commit details
    Browse the repository at this point in the history