Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: yarn upgrade #19395

Closed
wants to merge 11 commits into from
Closed

chore: yarn upgrade #19395

wants to merge 11 commits into from

Conversation

comcalvi
Copy link
Contributor

@comcalvi comcalvi commented Mar 14, 2022

woops, this is the wrong change: see #19454 for the actual change.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@comcalvi comcalvi requested a review from a team March 14, 2022 22:12
@gitpod-io
Copy link

gitpod-io bot commented Mar 14, 2022

@github-actions github-actions bot added the @aws-cdk/aws-sso Related to the @aws-cdk/aws-sso package label Mar 14, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 14, 2022
@yuth
Copy link
Contributor

yuth commented Mar 14, 2022

Don't we need to pin the aws-sdk version to 2.1093.0 instead of updating the yarn.lock as the lock file is development time only.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 8bfe351
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@polothy
Copy link
Contributor

polothy commented Mar 15, 2022

Looking at the build log:

aws-cdk: In package package.json
aws-cdk: - [bundle/outdated-attributions] THIRD_PARTY_LICENSES is outdated (fixable)
aws-cdk: Error: Some package.json files had errors
aws-cdk:     at main (/codebuild/output/src901086373/src/github.com/aws/aws-cdk/tools/@aws-cdk/pkglint/bin/pkglint.js:30:15)
aws-cdk:     at Object.<anonymous> (/codebuild/output/src901086373/src/github.com/aws/aws-cdk/tools/@aws-cdk/pkglint/bin/pkglint.js:33:1)
aws-cdk:     at Module._compile (internal/modules/cjs/loader.js:999:30)
aws-cdk:     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
aws-cdk:     at Module.load (internal/modules/cjs/loader.js:863:32)
aws-cdk:     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
aws-cdk:     at Module.require (internal/modules/cjs/loader.js:887:19)
aws-cdk:     at require (internal/modules/cjs/helpers.js:74:18)
aws-cdk:     at Object.<anonymous> (/codebuild/output/src901086373/src/github.com/aws/aws-cdk/tools/@aws-cdk/pkglint/bin/pkglint:2:1)
aws-cdk:     at Module._compile (internal/modules/cjs/loader.js:999:30)
aws-cdk: Error: pkglint exited with error code 1

So, maybe just need to run pkglint locally?

@polothy
Copy link
Contributor

polothy commented Mar 15, 2022

Well, I couldn't get it to run locally. But thanks for this effort, getting SSO support will be absolutely wonderful, cannot wait 😄

@comcalvi
Copy link
Contributor Author

closing this in favor of #19454

@comcalvi comcalvi closed this Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-sso Related to the @aws-cdk/aws-sso package contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants