Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iam): IAM Policies are too large to deploy #19114

Merged
merged 37 commits into from Mar 18, 2022
Merged

fix(iam): IAM Policies are too large to deploy #19114

merged 37 commits into from Mar 18, 2022

Commits on Feb 23, 2022

  1. fix(iam): IAM Policies are too large to deploy 

    The policies we generate sometimes have a lot of duplication between
statements. This duplication can lead to the policy going over the size
limit an IAM policy (either 2k, 6k or 10k bytes, depending on the resource
type).

This change combines multiple statements together, as long as it
doesn't change the meaning of the final policy.

Because doing so for all existing stacks will probably provoke minor
heart attacks in operators everywhere, the new behavior is gated
behind a feature flag. It can be retroactively switched on by
people currently being bit by the size issues:

```
@aws-cdk/aws-iam:minimizePolicies
```

Fixes #18774, fixes #16350, fixes #18457.
    @rix0rrr
    rix0rrr committed Feb 23, 2022
    Copy the full SHA
    f8208e9 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Add unit tests

    @rix0rrr
    rix0rrr committed Feb 24, 2022
    Copy the full SHA
    777c24d View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2022

  1. Only merge objects for principals

    @rix0rrr
    rix0rrr committed Feb 25, 2022
    Copy the full SHA
    e9b6cdc View commit details
    Browse the repository at this point in the history

  2. Add test for condition

    @rix0rrr
    rix0rrr committed Feb 25, 2022
    Copy the full SHA
    68d3940 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2022

  1. Update snapshots

    @rix0rrr
    rix0rrr committed Feb 26, 2022
    Copy the full SHA
    243f9c0 View commit details
    Browse the repository at this point in the history

  2. Also merge Deny statements, add Alloy model

    @rix0rrr
    rix0rrr committed Feb 26, 2022
    Copy the full SHA
    1f40baa View commit details
    Browse the repository at this point in the history

  3. Revert "Update snapshots" 

    This reverts commit 243f9c0.
    @rix0rrr
    rix0rrr committed Feb 26, 2022
    Copy the full SHA
    ef260c2 View commit details
    Browse the repository at this point in the history

  4. Add reference to Alloy model in source

    @rix0rrr
    rix0rrr committed Feb 26, 2022
    Copy the full SHA
    8b896d5 View commit details
    Browse the repository at this point in the history

  5. Correct docstring

    @rix0rrr
    rix0rrr committed Feb 26, 2022
    Copy the full SHA
    281df8b View commit details
    Browse the repository at this point in the history

  6. Don't unnecessarily update expectations

    @rix0rrr
    rix0rrr committed Feb 26, 2022
    Copy the full SHA
    a00582a View commit details
    Browse the repository at this point in the history

  7. Update packages/@aws-cdk/aws-iam/lib/policy-document.ts 

    Co-authored-by: Adam Ruka <adamruka@amazon.com>
    @rix0rrr @skinny85
    rix0rrr and skinny85 committed Feb 26, 2022
    Copy the full SHA
    aeb902f View commit details
    Browse the repository at this point in the history

  8. Add review comments

    @rix0rrr
    rix0rrr committed Feb 26, 2022
    Copy the full SHA
    adf50cb View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2022

  1. Redid merging logic

    @rix0rrr
    rix0rrr committed Feb 27, 2022
    Copy the full SHA
    ccb192b View commit details
    Browse the repository at this point in the history

  2. Update Alloy comment

    @rix0rrr
    rix0rrr committed Feb 27, 2022
    Copy the full SHA
    79f17d1 View commit details
    Browse the repository at this point in the history

  3. Not subsets, equal sets!

    @rix0rrr
    rix0rrr committed Feb 27, 2022
    Copy the full SHA
    09cdce1 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2022

  1. Update snapshots

    @rix0rrr
    rix0rrr committed Mar 2, 2022
    Copy the full SHA
    02274c3 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2022

  1. Update model some more

    @rix0rrr
    rix0rrr committed Mar 4, 2022
    Copy the full SHA
    ef354b4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'huijbers/minimize-policies' of github.com:aws/aws-cdk i… 

    …nto huijbers/minimize-policies
    @rix0rrr
    rix0rrr committed Mar 4, 2022
    Copy the full SHA
    00d0266 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Review comments

    @rix0rrr
    rix0rrr committed Mar 8, 2022
    Copy the full SHA
    cc54755 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. Update packages/@aws-cdk/aws-iam/lib/private/postprocess-policy-docum… 

    …ent.ts

Co-authored-by: Romain Marcadier <rmuller@amazon.lu>
    @rix0rrr
    rix0rrr and Romain Marcadier committed Mar 9, 2022
    Copy the full SHA
    e4c3a2a View commit details
    Browse the repository at this point in the history

  2. Remove unused helpers

    @rix0rrr
    rix0rrr committed Mar 9, 2022
    Copy the full SHA
    8fbee24 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into huijbers/minimize-p… 

    …olicies
    @rix0rrr
    rix0rrr committed Mar 9, 2022
    Copy the full SHA
    625b2a7 View commit details
    Browse the repository at this point in the history

  4. Update packages/@aws-cdk/aws-iam/lib/private/postprocess-policy-docum… 

    …ent.ts

Co-authored-by: Romain Marcadier <rmuller@amazon.lu>
    @rix0rrr
    rix0rrr and Romain Marcadier committed Mar 9, 2022
    Copy the full SHA
    8875096 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. Do better comparisons

    @rix0rrr
    rix0rrr committed Mar 10, 2022
    Copy the full SHA
    3e570f0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'huijbers/minimize-policies' of github.com:aws/aws-cdk i… 

    …nto huijbers/minimize-policies
    @rix0rrr
    rix0rrr committed Mar 10, 2022
    Copy the full SHA
    fe4be84 View commit details
    Browse the repository at this point in the history

  3. Some implementation details

    @rix0rrr
    rix0rrr committed Mar 10, 2022
    Copy the full SHA
    812d4fb View commit details
    Browse the repository at this point in the history

  4. Update snapshots

    @rix0rrr
    rix0rrr committed Mar 10, 2022
    Copy the full SHA
    fac4952 View commit details
    Browse the repository at this point in the history

  5. More snapshot updates

    @rix0rrr
    rix0rrr committed Mar 10, 2022
    Copy the full SHA
    bdb113f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into huijbers/minimize-policies

    @rix0rrr
    rix0rrr committed Mar 10, 2022
    Copy the full SHA
    1f0b3c4 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Silly copy/paste bug 😓

    @rix0rrr
    rix0rrr committed Mar 14, 2022
    Copy the full SHA
    4988a90 View commit details
    Browse the repository at this point in the history

  2. Reformat, find another weakening

    @rix0rrr
    rix0rrr committed Mar 14, 2022
    Copy the full SHA
    2d2f16b View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into huijbers/minimize-p… 

    …olicies
    @rix0rrr
    rix0rrr committed Mar 14, 2022
    Copy the full SHA
    e1f701c View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Also handle untyped principals, review comments

    @rix0rrr
    rix0rrr committed Mar 17, 2022
    Copy the full SHA
    8eb3cfa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'huijbers/minimize-policies' of github.com:aws/aws-cdk i… 

    …nto huijbers/minimize-policies
    @rix0rrr
    rix0rrr committed Mar 17, 2022
    Copy the full SHA
    80d7a07 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into huijbers/minimize-policies

    @rix0rrr
    rix0rrr committed Mar 17, 2022
    Copy the full SHA
    793da77 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. Update new integ

    @rix0rrr
    rix0rrr committed Mar 18, 2022
    Copy the full SHA
    4fb02ef View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into huijbers/minimize-policies

    @mergify
    mergify[bot] committed Mar 18, 2022
    Copy the full SHA
    37eaa56 View commit details
    Browse the repository at this point in the history