Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): hotswapping is slow for many resources deployed at once #19081

Merged
merged 3 commits into from Feb 24, 2022
Merged

fix(cli): hotswapping is slow for many resources deployed at once #19081

merged 3 commits into from Feb 24, 2022

Commits on Feb 21, 2022

  1. fix(cli): hotswapping is slow for many resources deployed at once 

    In the `LazyListStackResources` class,
we were incorrectly caching the results of the ListStackResources CloudFormation API call.
This resulted in executing redundant calls,
and very visibly impacted the performance of hotswapping when the Stack included many resources.

In manual testing, this change brought down deployment time of a large Stack from 80 to 7 seconds.

Closes aws#19021
    @skinny85
    skinny85 committed Feb 21, 2022
    Copy the full SHA
    841a255 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Merge branch 'master' into hotswap-list-stack-res-spam

    @mergify
    mergify[bot] committed Feb 24, 2022
    Copy the full SHA
    51bd290 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into hotswap-list-stack-res-spam

    @mergify
    mergify[bot] committed Feb 24, 2022
    Copy the full SHA
    a088965 View commit details
    Browse the repository at this point in the history