Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: API compatibility check fails in CI pipeline #19069

Merged
merged 2 commits into from Feb 22, 2022
Merged

fix: API compatibility check fails in CI pipeline #19069

merged 2 commits into from Feb 22, 2022

Commits on Feb 22, 2022

  1. fix: API compatibility check fails in CI pipeline 

    In the master build, we do a version bump which turns `1.146.0` into
`1.146.0-rc.0`, which makes the API compatibility checker try to install
packages with those versions.

Because none of those packages exist, the list of packages ends up
empty, which turns our `npm install $PACKAGES` command into `npm
install`, which subsequently complains that there's no `package.json`.

In order to make this work properly, we need to query the ACTUAL
released version numbers on GitHub so we can properly find the
version to diff against.
    @rix0rrr
    rix0rrr committed Feb 22, 2022
    Copy the full SHA
    b1f2590 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into huijbers/fix-version-compat-script

    @mergify
    mergify[bot] committed Feb 22, 2022
    Copy the full SHA
    53e5f00 View commit details
    Browse the repository at this point in the history