feat(aws-codepipeline-actions): Added region as prop of LambdaInvokeAction

[ryparker]

Summary

This PR adds the missing prop region to the LambdaInvokeAction.

Fixes: #18228

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[skinny85]

This is a good attempt, but the region should be taken from the Function passed in the lambda property, not separately 🙂.

[ryparker]

This is a good attempt, but the region should be taken from the Function passed in the lambda property, not separately 🙂.

That sounds ideal however it would cause an error on any pipeline stack that does not have region specified.

Error: Resolution error: Resolution error: Resolution error: Pipeline stack which uses cross-environment actions must have an explicitly set region.

In this case we're allowing the user to configure the LambdaInvokeAction's region only when necessary. If we default to using the Lambda's region then the above error will break any current usage that does not have region specified on the pipeline's stack.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: d659953
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[skinny85]

This is a good attempt, but the region should be taken from the Function passed in the lambda property, not separately 🙂.

That sounds ideal however it would cause an error on any pipeline stack that does not have region specified.

Error: Resolution error: Resolution error: Resolution error: Pipeline stack which uses cross-environment actions must have an explicitly set region.

In this case we're allowing the user to configure the LambdaInvokeAction's region only when necessary. If we default to using the Lambda's region then the above error will break any current usage that does not have region specified on the pipeline's stack.

Yep, that's expected behavior, like the error message says. If you provide a Lambda function from a specific region, you must also tell us what region the pipeline is in, because if the two are different, this means this is a cross-region CodePipeline, and we must do some additional stuff to make it work. The construct handles all of that in its implementation, but we need to have a specific region to make sure the pipeline is indeed cross-region.

We already take the region from the Lambda function here, so I'm curious what is causing the incorrect behavior in the original issue.

[cgarvis]

#18228 was closed by #18255. So seems like this is not needed anymore.