Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): no longer disable rollback by default for hotswap deployments #17317

Merged
merged 2 commits into from Nov 4, 2021

Commits on Nov 3, 2021

  1. fix(cli): no longer disable rollback by default for hotswap deployments

    Previously, we would default the --rollback flag to `false` if it wasn't provided
    if the `--hotswap` option was also passed to `cdk deploy`.
    However, disabled rollback does not play well with deployments that cause replacements -
    they fail, and leave the Stack in a weird state.
    For that reason, stop disabling rollback by default.
    It's still possible to disable easily if wanted by using the `-R` switch.
    
    Fixes aws#17267
    skinny85 committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    e7b798b View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. Configuration menu
    Copy the full SHA
    97a0497 View commit details
    Browse the repository at this point in the history