Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws-eks): proxy support and allow assigning a security group to all cluster handler functions #17200
fix(aws-eks): proxy support and allow assigning a security group to all cluster handler functions #17200
Changes from 8 commits
0d87a93
dcfb784
cd4578e
0e0da6f
cb10cce
4ab257a
d569176
5208526
dbfe9a6
92a6c39
d3f71a7
3ff5d7e
9a0c15e
d485430
2949fbf
68f7655
a9a502c
6593348
223e6fb
1d3a3b8
07ca90a
991bb0d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the name change...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for the name change is because the proxy-agent layer is now being used in both
onEventHandler
andisCompleteHandler
Lambdas. Because of this change i've deprecated the originalonEventLayer
and created a new propproxyAgentLayer
since we will now be passing this prop into more than just theonEventHandler
Lambda.The
onEventLayer
prop was introduced a few weeks ago (sept 24) so it should not impact many users (if any). The prop would only be used if the user wishes to bundle the layer themselves with a custom proxy agent.This prop follows the same user customization we allow with the kubectl handler. However if we'd rather not allow users to override that layer then we may still want to deprecate the
onEventLayer
prop since it is no longer being used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're over optimizing here. Can we just leave everything as is as far as layers go and simply add the
NodeProxyAgentLayer
to the lambda's that needed and thats it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing. I'll remove the new prop and leave the
onEventLayer
prop. I'll also reconnect theonEventLayer
to theonEventLambda
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think this should be configurable. The lambda function code now must have this layer in order to work, so we should simply be adding it in addition to the externally provided layer.