Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipelines): add property to specify a namespace so exported variables can be used #15964

Closed
wants to merge 6 commits into from
Closed

feat(pipelines): add property to specify a namespace so exported variables can be used #15964

wants to merge 6 commits into from

Commits on Aug 10, 2021

  1. feat(pipelines): add property to specify a namespace so exported vari… 

    …ables can be used elsewhere
    @berenddeboer
    berenddeboer committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    871ba5b View commit details
    Browse the repository at this point in the history

  2. chore(deps): bump actions/setup-node from 2.3.0 to 2.4.0 (aws#15942) 

    Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2.3.0 to 2.4.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v2.3.0...v2.4.0)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot @berenddeboer
    dependabot[bot] authored and berenddeboer committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    576b08d View commit details
    Browse the repository at this point in the history

  3. chore(sam): explicit feature flags to produce a consistent template d… 

    …uring tests (aws#15953)

In v1, the default value of the @aws-cdk/core:newStyleStackSynthesis flag is false. As a consequence, Template.fromStack() generates, by default, a template without the rule and parameter related to bootstrap versions. In v2, the default value of this flag is true. So this test fails in the v2 branch. By explicitly setting the flag to false, we ensure that the tests passes on both v1 and v2, regardless of the default values.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @madeline-k @berenddeboer
    madeline-k authored and berenddeboer committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    3c0e3e0 View commit details
    Browse the repository at this point in the history

  4. chore(servicecatalogappregistry): explicit feature flags to produce a… 

    … consistent template during tests (aws#15955)

In v1, the default value of the `@aws-cdk/core:newStyleStackSynthesis` flag is `false`. As a consequence, `Template.fromStack()` generates, by default, a template without the rule and parameter related to bootstrap versions. In v2,  the default value of this flag is `true`. So this test fails in the v2 branch. By explicitly setting the flag to `false`, we ensure that the tests passes on both v1 and v2, regardless of the default values.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @madeline-k @berenddeboer
    madeline-k authored and berenddeboer committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    cae250a View commit details
    Browse the repository at this point in the history

  5. chore(glue, ivs, msk, servicecatalog): explicit feature flags to prod… 

    …uce a consistent template during tests (aws#15960)

In v1, the default value of the `@aws-cdk/core:newStyleStackSynthesis` flag is `false`. As a consequence, `Template.fromStack()` generates, by default, a template without the rule and parameter related to bootstrap versions. In v2,  the default value of this flag is `true`. So this test fails in the v2 branch. By explicitly setting the flag to `false`, we ensure that the tests passes on both v1 and v2, regardless of the default values.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @madeline-k @berenddeboer
    madeline-k authored and berenddeboer committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    91630ff View commit details
    Browse the repository at this point in the history

  6. docs(pipelines): mention variableNamespace

    @berenddeboer
    berenddeboer committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    90f3e11 View commit details
    Browse the repository at this point in the history