Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecs): TagParameterContainerImage cannot be used across accounts #15073

Merged
merged 4 commits into from Jun 15, 2021
Merged

fix(ecs): TagParameterContainerImage cannot be used across accounts #15073

merged 4 commits into from Jun 15, 2021

Commits on Jun 10, 2021

  1. fix(ecs): TagParameterContainerImage cannot be used across accounts 

    When TagParameterContainerImage is used from a different acocunt than the service itself is in,
it fails resolution, because the Task's execution Role does not have a physical name set by default.
Create it with PhysicalName.GENERATE_IF_NEEDED, so that it assigns a name when accessed from a cross-account context.

Fixes aws#15070
    @skinny85
    skinny85 committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    17e9945 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. Merge branch 'master' into fix/cross-account-tag-param-container-image

    @SoManyHs
    SoManyHs committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    cddf6e4 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. Merge branch 'master' into fix/cross-account-tag-param-container-image

    @SoManyHs
    SoManyHs committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    34b96b1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/cross-account-tag-param-container-image

    @mergify
    mergify[bot] committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    685fafe View commit details
    Browse the repository at this point in the history