fix(elasticsearch): Vpc.fromLookup is unusable in Domain construct #12242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This also begs another question, should we maybe move the context lookup away from the CLI and into the framework, invoking it just before the |
github-actions
bot
added
the
@aws-cdk/aws-elasticsearch
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Domainconstruct accepts a list of subnets and performs a validation on them. When using subnets that come from a looked up VPC, the VPC properties that are used during the first synthesis cycle is that of the dummy VPC.This means that we cannot perform such a validation blindly without considering the VPC might be a dummy, only to be retrieved during the second synthesis cycle.
Im open for other suggestions on how to implement this because i'm definitely not in love with the current solution.
Fixes #12078
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license