Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-autoscaling: support defaultInstanceWarmup #23180

Closed
1 of 2 tasks
pb8o opened this issue Nov 30, 2022 · 7 comments
Closed
1 of 2 tasks

aws-autoscaling: support defaultInstanceWarmup #23180

pb8o opened this issue Nov 30, 2022 · 7 comments
Assignees
Labels
@aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@pb8o
Copy link

pb8o commented Nov 30, 2022

Describe the feature

Support defaultInstanceWarmup in the AutoScalingGroup L2 construct.

Currently it is not supporter and the docs state:

Not currently supported by CloudFormation.

Which is not the case anymore

Use Case

Right now we have to use the escape hatch.

const cfnASG = asg.node.defaultChild as autoscaling.CfnAutoScalingGroup;
cfnASG.defaultInstanceWarmup = 60;

Proposed Solution

Expose the feature through the L2 Construct.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.45.0

Environment details (OS name and version, etc.)

Ubuntu 20.04

@pb8o pb8o added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 30, 2022
@github-actions github-actions bot added the @aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling label Nov 30, 2022
@pahud
Copy link
Contributor

pahud commented Dec 1, 2022

Awesome! Thanks for your PR!!

@pahud pahud added good first issue Related to contributions. See CONTRIBUTING.md p2 and removed needs-triage This issue or PR still needs to be triaged. labels Dec 1, 2022
@HBobertz HBobertz assigned HBobertz and unassigned comcalvi Dec 2, 2022
@HBobertz
Copy link
Contributor

HBobertz commented Dec 2, 2022

I don't see a PR for this? I'll pick this up if there isn't

@pb8o
Copy link
Author

pb8o commented Dec 2, 2022

Yeah there isn't one. Thanks for picking it!

@HBobertz
Copy link
Contributor

HBobertz commented Dec 9, 2022

Unsure if there is a better way to link this pr. But here it is: #23285

@atchla
Copy link

atchla commented Dec 27, 2022

Should this be closed? The linked PR has been merged but it looks like it didn't get auto-associated with this issue somehow @pahud @pb8o

@pb8o
Copy link
Author

pb8o commented Jan 5, 2023

Yep. Thanks!

@pb8o pb8o closed this as completed Jan 5, 2023
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Development

No branches or pull requests

5 participants