Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DefaultInstanceWarmup of AutoScalingGroup #1216

Closed
BDeus opened this issue Jun 15, 2022 · 1 comment
Closed

Support DefaultInstanceWarmup of AutoScalingGroup #1216

BDeus opened this issue Jun 15, 2022 · 1 comment
Labels

Comments

@BDeus
Copy link

BDeus commented Jun 15, 2022

Name of the resource

AWS::AutoScaling::AutoScalingGroup

Resource name

No response

Description

The Property of AutoScalingGroup DefaultInstanceWarmup is the recommended way by AWS to declared the warmup at group level and not alarm one.

Cloudformation has enabled the possibility to set it but it's currently unsupported as documentation mention

Other Details

No response

@BDeus BDeus added the Coverage label Jun 15, 2022
@rgoltz
Copy link

rgoltz commented Dec 31, 2022

Hi @BDeus - The CloudFormation documentation now worded support for DefaultInstanceWarmup as setting for AWS::AutoScaling::AutoScalingGroup. It's also already supported in CDK as well: aws/aws-cdk#23285 + aws/aws-cdk#23180

Based on our last testing, there's a catch: Once you set DefaultInstanceWarmup in your CFN Template, CloudFormation Drift Detection reporting this valid and correctly set property as a drift. It's a false-postive, which needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants