feat(aws-cognito): add AuthSessionValidity property on a UserPoolClient #23040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
effort/small
aws-cdk-automation
previously requested changes
Nov 22, 2022
drumnistnakano
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
drumnistnakano
changed the title
2 tasks
comcalvi
previously requested changes
Nov 30, 2022
Comment on lines
38
to
59
| ## Table of Contents | ||
|
|
||
| - [User Pools](#user-pools) | ||
| - [Sign Up](#sign-up) | ||
| - [Sign In](#sign-in) | ||
| - [Attributes](#attributes) | ||
| - [Security](#security) | ||
| - [Multi-factor Authentication](#multi-factor-authentication-mfa) | ||
| - [Account Recovery Settings](#account-recovery-settings) | ||
| - [Emails](#emails) | ||
| - [Device Tracking](#device-tracking) | ||
| - [Lambda Triggers](#lambda-triggers) | ||
| - [Trigger Permissions](#trigger-permissions) | ||
| - [Import](#importing-user-pools) | ||
| - [Identity Providers](#identity-providers) | ||
| - [App Clients](#app-clients) | ||
| - [Resource Servers](#resource-servers) | ||
| - [Domains](#domains) | ||
| - [Deletion protection](#deletion-protection) | ||
| - [Amazon Cognito Construct Library](#amazon-cognito-construct-library) | ||
| - [Table of Contents](#table-of-contents) | ||
| - [User Pools](#user-pools) | ||
| - [Sign Up](#sign-up) | ||
| - [Sign In](#sign-in) | ||
| - [Attributes](#attributes) | ||
| - [Attribute verification](#attribute-verification) | ||
| - [Security](#security) | ||
| - [Multi-factor Authentication (MFA)](#multi-factor-authentication-mfa) | ||
| - [Account Recovery Settings](#account-recovery-settings) | ||
| - [Emails](#emails) | ||
| - [Device Tracking](#device-tracking) | ||
| - [Lambda Triggers](#lambda-triggers) | ||
| - [Trigger Permissions](#trigger-permissions) | ||
| - [Importing User Pools](#importing-user-pools) | ||
| - [Identity Providers](#identity-providers) | ||
| - [App Clients](#app-clients) | ||
| - [Resource Servers](#resource-servers) | ||
| - [Domains](#domains) | ||
| - [Deletion protection](#deletion-protection) |
There was a problem hiding this comment.
Why...? Can leave this as it was?
There was a problem hiding this comment.
I'm sorry... My local VSCode formatter was formatting the contents of the README.
This is not related to this PR, so I have corrected it back.
mergify
bot
dismissed
comcalvi’s stale review
Pull request has been modified.
drumnistnakano
requested review from
comcalvi
and removed request for
aws-cdk-automation
comcalvi
previously approved these changes
Dec 7, 2022
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify
bot
dismissed
comcalvi’s stale review
Pull request has been modified.
comcalvi
approved these changes
Dec 20, 2022
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
brennanho
pushed a commit
to brennanho/aws-cdk
that referenced
this pull request
Jan 20, 2023
…nt (aws#23040) Fixes aws#22854 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho
pushed a commit
to brennanho/aws-cdk
that referenced
this pull request
Feb 22, 2023
…nt (aws#23040) Fixes aws#22854 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22854
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license