Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_cognito: allow setting AuthSessionValidity on a UserPoolClient #22854

Closed
2 tasks
smerrill opened this issue Nov 9, 2022 · 7 comments · Fixed by #23040
Closed
2 tasks

aws_cognito: allow setting AuthSessionValidity on a UserPoolClient #22854

smerrill opened this issue Nov 9, 2022 · 7 comments · Fixed by #23040
Assignees
@corymhall
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@smerrill
Copy link

smerrill commented Nov 9, 2022 •
edited

Describe the feature

Currently there is no way to set AuthSessionValidity on a UserPoolClient.

Use Case

This is an important feature for our application and I had to go switch the value by hand on all my User Pool Clients when I discovered that they were set to 3 minutes.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.50.0

Environment details (OS name and version, etc.)

Ubuntu 20.04 LTS running in WSL2
@smerrill smerrill added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 9, 2022
@github-actions github-actions bot added the @aws-cdk/aws-cognito Related to Amazon Cognito label Nov 9, 2022
@papiro
Copy link

papiro commented Nov 10, 2022

This is already available: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_cognito.UserPoolClient.html#accesstokenvalidity

@smerrill smerrill changed the title aws_cognito: allow setting AccessTokenValidity on a UserPoolClient aws_cognito: allow setting AuthSessionValidity on a UserPoolClient Nov 10, 2022
@smerrill
Copy link
Author

Apologies; I meant AuthSessionValidity and I have updated the issue.

@papiro
Copy link

papiro commented Nov 10, 2022

Ahhh ok! I just opened up a ticket for the same. I'll try to link this one to the one I just opened.

@papiro papiro mentioned this issue Nov 10, 2022
Closed
@papiro
Copy link

papiro commented Nov 10, 2022

My issue is #22868

@peterwoodworth
Copy link
Contributor

Thanks for the feature request!

This should be pretty easy to add as a prop that goes into here

aws-cdk/packages/@aws-cdk/aws-cognito/lib/user-pool-client.ts

Line 396 in 4c11af6

const resource = new CfnUserPoolClient(this, 'Resource', {

You can use this feature in CDK for now with escape hatches, something like this should work:

const client = new UserPoolClient(...);
(client.node.defaultChild as CfnUserPoolClient).addPropertyOverride('AuthSessionValidity', ...);

I am marking this issue as p2, which means that we are unable to work on this immediately.

We use +1s to help prioritize our work, and are happy to revaluate this issue based on community feedback. You can reach out to the cdk.dev community on Slack to solicit support for reprioritization.

Check out our contributing guide if you're interested in contributing yourself - there's a low chance the team will be able to address this soon but we'd be happy to review a PR 🙂

@peterwoodworth peterwoodworth added good first issue Related to contributions. See CONTRIBUTING.md p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 10, 2022
@drumnistnakano drumnistnakano mentioned this issue Nov 22, 2022
Merged
4 tasks
@drumnistnakano
Copy link
Contributor

Hi @corymhall,
I have created a PR for this issue: #23040
Could you please review it at your convenience?

@mergify mergify bot closed this as completed in #23040 Dec 20, 2022
mergify bot pushed a commit that referenced this issue Dec 20, 2022
@drumnistnakano
feat(aws-cognito): add AuthSessionValidity property on a UserPoolClie…
8896fb9 
…nt (#23040)

Fixes #22854

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

brennanho pushed a commit to brennanho/aws-cdk that referenced this issue Jan 20, 2023
@drumnistnakano
feat(aws-cognito): add AuthSessionValidity property on a UserPoolClie…
45d7e09 
…nt (aws#23040)

Fixes aws#22854

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho pushed a commit to brennanho/aws-cdk that referenced this issue Feb 22, 2023
@drumnistnakano
feat(aws-cognito): add AuthSessionValidity property on a UserPoolClie…
539b065 
…nt (aws#23040)

Fixes aws#22854

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corymhall corymhall

Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(aws-cognito): add AuthSessionValidity property on a UserPoolClient drumnistnakano/aws-cdk
5 participants
@smerrill @papiro @drumnistnakano @corymhall @peterwoodworth