fix: API compatibility check fails in CI pipeline #19069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kaizencc
approved these changes
Feb 21, 2022
rix0rrr
added
pr-linter/exempt-readme
In the master build, we do a version bump which turns `1.146.0` into `1.146.0-rc.0`, which makes the API compatibility checker try to install packages with those versions. Because none of those packages exist, the list of packages ends up empty, which turns our `npm install $PACKAGES` command into `npm install`, which subsequently complains that there's no `package.json`. In order to make this work properly, we need to query the ACTUAL released version numbers on GitHub so we can properly find the version to diff against.
rix0rrr
force-pushed
the
huijbers/fix-version-compat-script
branch
from
f995581
to
b1f2590
Compare
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-roll of #19070, fixing a bug introduced in that one.
In the master build, we do a version bump which turns
1.146.0into1.146.0-rc.0, which makes the API compatibility checker try to installpackages with those versions.
Because none of those packages exist, the list of packages ends up
empty, which turns our
npm install $PACKAGEScommand intonpm install, which subsequently complains that there's nopackage.json.In order to make this work properly, we need to query the ACTUAL
released version numbers on GitHub so we can properly find the
version to diff against.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license