Skip to content

Commit

Permalink
chore: remove invalid test (#17337)
Browse files Browse the repository at this point in the history
  • Loading branch information
iliapolo committed Nov 4, 2021
1 parent ea56e69 commit b9c00f0
Showing 1 changed file with 1 addition and 23 deletions.
24 changes: 1 addition & 23 deletions packages/aws-cdk/test/integ/cli/bootstrapping.integtest.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as fs from 'fs';
import * as path from 'path';
import { MAJOR_VERSION, randomString, withDefaultFixture } from '../helpers/cdk';
import { randomString, withDefaultFixture } from '../helpers/cdk';
import { integTest } from '../helpers/test-helpers';

const timeout = process.env.CODEBUILD_BUILD_ID ? // if the process is running in CodeBuild
Expand Down Expand Up @@ -129,28 +129,6 @@ integTest('deploy old style synthesis to new style bootstrap', withDefaultFixtur
});
}));

if (MAJOR_VERSION === '1') {
// For v2, the default bootstrap is the modern bootstrap, so this test is predicated on invalid
// assumptions.

integTest('deploying new style synthesis to old style bootstrap fails', withDefaultFixture(async (fixture) => {
const bootstrapStackName = fixture.bootstrapStackName;

await fixture.cdkBootstrapLegacy({
toolkitStackName: bootstrapStackName,
});

// Deploy stack that uses file assets, this fails because the bootstrap stack
// is version checked.
await expect(fixture.cdkDeploy('lambda', {
options: [
'--toolkit-stack-name', bootstrapStackName,
'--context', '@aws-cdk/core:newStyleStackSynthesis=1',
],
})).rejects.toThrow('exited with error');
}));
}

integTest('can create a legacy bootstrap stack with --public-access-block-configuration=false', withDefaultFixture(async (fixture) => {
const bootstrapStackName = fixture.bootstrapStackName;

Expand Down

0 comments on commit b9c00f0

Please sign in to comment.