Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: regenerate attributions on automatic dependency upgrades (#19439)
Even since #18667, our build process validates that the `THIRD_PARTY_LICENSES` file of the CLI package is up to date. That is, the version of it committed to source code matches the one being auto generated. This behavior breaks our automatic dependency upgrades whenever it includes an upgrade to one of the CLI's dependencies. This is because the autogenerated file will (for sure) have different dependency versions, and possibly also include new transitive dependencies. This manifests an error like so: ```console aws-cdk: In package package.json aws-cdk: - [bundle/outdated-attributions] THIRD_PARTY_LICENSES is outdated (fixable) aws-cdk: Error: Some package.json files had errors ``` To fix this, we currently need to manually regenerate the `THIRD_PARTY_LICENSES` file by running `yarn pkglint` on the CLI package. > For example: 5ca8ebf This PR adds a regeneration step to the upgrade workflow so that the PR also includes the up to date document. Note that if this doesn't mean attribution validation will always pass. If any dependencies changed licenses to one that isn't allowlisted, the validation will still fail. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information