Skip to content

Commit

Permalink
docs(ecs): update docs to accurately reflect that a new security grou…
Browse files Browse the repository at this point in the history
…p is created if one is not provided. (#17364)

Closes #15365


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
madeline-k authored and iliapolo committed Nov 7, 2021
1 parent 7317455 commit 30a001f
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export interface ApplicationLoadBalancedFargateServiceProps extends ApplicationL
readonly platformVersion?: FargatePlatformVersion;

/**
* The security groups to associate with the service. If you do not specify a security group, the default security group for the VPC is used.
* The security groups to associate with the service. If you do not specify a security group, a new security group is created.
*
* @default - A new security group is created.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export interface QueueProcessingFargateServiceProps extends QueueProcessingServi
readonly taskSubnets?: ec2.SubnetSelection;

/**
* The security groups to associate with the service. If you do not specify a security group, the default security group for the VPC is used.
* The security groups to associate with the service. If you do not specify a security group, a new security group is created.
*
* @default - A new security group is created.
*/
Expand Down
4 changes: 2 additions & 2 deletions packages/@aws-cdk/aws-ecs/lib/ec2/ec2-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export interface Ec2ServiceProps extends BaseServiceOptions {
readonly vpcSubnets?: ec2.SubnetSelection;

/**
* The security groups to associate with the service. If you do not specify a security group, the default security group for the VPC is used.
* The security groups to associate with the service. If you do not specify a security group, a new security group is created.
*
* This property is only used for tasks that use the awsvpc network mode.
*
Expand All @@ -49,7 +49,7 @@ export interface Ec2ServiceProps extends BaseServiceOptions {
readonly securityGroup?: ec2.ISecurityGroup;

/**
* The security groups to associate with the service. If you do not specify a security group, the default security group for the VPC is used.
* The security groups to associate with the service. If you do not specify a security group, a new security group is created.
*
* This property is only used for tasks that use the awsvpc network mode.
*
Expand Down
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-ecs/lib/external/external-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export interface ExternalServiceProps extends BaseServiceOptions {
readonly taskDefinition: TaskDefinition;

/**
* The security groups to associate with the service. If you do not specify a security group, the default security group for the VPC is used.
* The security groups to associate with the service. If you do not specify a security group, a new security group is created.
*
*
* @default - A new security group is created.
Expand Down
4 changes: 2 additions & 2 deletions packages/@aws-cdk/aws-ecs/lib/fargate/fargate-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,15 @@ export interface FargateServiceProps extends BaseServiceOptions {
readonly vpcSubnets?: ec2.SubnetSelection;

/**
* The security groups to associate with the service. If you do not specify a security group, the default security group for the VPC is used.
* The security groups to associate with the service. If you do not specify a security group, a new security group is created.
*
* @default - A new security group is created.
* @deprecated use securityGroups instead.
*/
readonly securityGroup?: ec2.ISecurityGroup;

/**
* The security groups to associate with the service. If you do not specify a security group, the default security group for the VPC is used.
* The security groups to associate with the service. If you do not specify a security group, a new security group is created.
*
* @default - A new security group is created.
*/
Expand Down

0 comments on commit 30a001f

Please sign in to comment.