Skip to content

Commit

Permalink
chore: remove and ignore intermediate snapshots integration test snap…
Browse files Browse the repository at this point in the history
…shots (#22731)

When running integration tests, they are executed inside an intermediate directory named `cdk-integ.out.*`. These files should never be committed to version control. This change removes the last few accidentally committed files, and adds a global gitignore rule to prevent any files being added in future.

The unit tests for `integ-runner` rely on these (fake) intermediate artifacts for assertions, so they are still included. However these aren't real integreation tests anyway.

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
mrgrain committed Nov 1, 2022
1 parent 1c707eb commit 29254fe
Show file tree
Hide file tree
Showing 8 changed files with 5 additions and 419 deletions.
1 change: 1 addition & 0 deletions .gitignore
Expand Up @@ -34,6 +34,7 @@ cdk.context.json
.cdk.staging/
cdk.out/
*.tabl.json
cdk-integ.out.*/

# Yarn error log
yarn-error.log
Expand Down
1 change: 0 additions & 1 deletion packages/@aws-cdk/aws-lambda/test/cdk-integ.out/cdk.out

This file was deleted.

This file was deleted.

This file was deleted.

70 changes: 0 additions & 70 deletions packages/@aws-cdk/aws-lambda/test/cdk-integ.out/manifest.json

This file was deleted.

143 changes: 0 additions & 143 deletions packages/@aws-cdk/aws-lambda/test/cdk-integ.out/tree.json

This file was deleted.

4 changes: 4 additions & 0 deletions packages/@aws-cdk/integ-runner/.gitignore
Expand Up @@ -27,7 +27,11 @@ junit.xml
# Ignore this symlink, we recreate it at test time
test/test-archive-follow/data/linked

# These files are needed for unit tests
!test/test-data/cdk-integ.out*/

!**/*.snapshot/**/asset.*/*.js
!**/*.snapshot/**/asset.*/*.d.ts

!**/*.snapshot/**/asset.*/**

0 comments on commit 29254fe

Please sign in to comment.