Add VlanId in the cmdAdd Result struct #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgchinmay
force-pushed
the
vlan_id_fix
branch
from
2106de3
to
d377d7c
Compare
cgchinmay
changed the title
|
Can you please fix the conflict - test/framework/resources/k8s/utils/daemonset.go |
cgchinmay
force-pushed
the
vlan_id_fix
branch
2 times, most recently
from
1b29040
to
deb1f0c
Compare
cgchinmay
changed the title
cgchinmay
force-pushed
the
vlan_id_fix
branch
from
deb1f0c
to
212dbe5
Compare
This VlanId will appear in the prevResult during cmdDel request CleanUp Pod Network using vlanId from prevResult in CNI itself Skip processing Delete request if prevResult is nil Add Logging vlanId to ipamd Add support to test with containerd nodegroup in pod-eni test Add check for empty Netns() in cni Updated test agent version and Image
cgchinmay
force-pushed
the
vlan_id_fix
branch
from
212dbe5
to
aed7b29
Compare
|
@cgchinmay - Even here branch needs update. |
Updated Prefix for dummyVlanInterface name
# Conflicts: # go.mod
jayanthvn
reviewed
Jan 27, 2022
jayanthvn
reviewed
Jan 27, 2022
jayanthvn
reviewed
Jan 27, 2022
Add relevant comments
cgchinmay
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This VlanId will appear in the prevResult during cmdDel request
The cni can then fetch the vlanId and delete the network associated with vlanId
This will help prevent calls made to api server from ipamd to fetch the vlan device information
#1644
#1313
Tested cni and ipamd integration tests
Test with e2e tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.