CannotPullContainerError/ASM error message enhancements #4181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineonine
force-pushed
the
cannot-pull-container-err-msg
branch
from
5dd5027
to
65a2859
Compare
Improve CannotPullContainerError message
nineonine
force-pushed
the
cannot-pull-container-err-msg
branch
2 times, most recently
from
0a68d36
to
ffcd9bf
Compare
nineonine
force-pushed
the
cannot-pull-container-err-msg
branch
from
ffcd9bf
to
dc51281
Compare
pallymore
reviewed
May 17, 2024
agent/vendor/github.com/aws/amazon-ecs-agent/ecs-agent/api/errors/error_messages.go
Outdated
Show resolved
Hide resolved
nineonine
commented
May 17, 2024
nineonine
force-pushed
the
cannot-pull-container-err-msg
branch
from
470ee7c
to
ec5361e
Compare
nineonine
force-pushed
the
cannot-pull-container-err-msg
branch
from
ec5361e
to
5d7418b
Compare
amogh09
reviewed
May 24, 2024
added 2 commits
May 30, 2024 23:40
* CannotPullContainerError: cleanup, renaming * ASM error: do not use added errormessages code - match on AWS SDK error directly, drop tracing prefix, fix/add more unit tests
amogh09
reviewed
May 30, 2024
amogh09
reviewed
May 31, 2024
nineonine
changed the title
|
Thanks for this change! Let's please add details about any manual tests performed to validate this changes. The new error messages seen in |
amogh09
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change does a few things:
CannotPullContainerError, spefically the missing ECR pull permissions, broken image repo url or non-existent repos.ResourceNotFoundExceptionasm_test.goimplementation to usegomockImplementation details
error_messages.goengine.pullAndUpdateContainerReferencewe use new functionality to attempt to update error message when image pull failed due CannotPullContainerErrorTesting
error_messages_test.goasm_test.godocker_task_engine_test.goto capture augmented message.asmsecret_test.goto account for removed prefix and updated messageNew tests cover the changes:
yes
Description for the changelog
Augment CannotPullContainerError/ ASM error messages with extra context to aid in troubleshooting
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.