Skip to content

Commit

Permalink
Fix invalid constraints and disable Unified Plan in safari 12.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@kaaaren
kaaaren committed Aug 4, 2020
1 parent fc9652b commit fe52357
Show file tree
Hide file tree
Showing 16 changed files with 3,747 additions and 3,540 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Ensure all simulcast stream resolution are 16-aligned to avoid pixel3(XL) encoder issue
- Fix race condition in Chromium browsers when consecutive audio bind operations take place
- Fix invalid constraints and disable Unified Plan in safari 12.0

## [1.14.0] - 2020-07-28

Expand Down
2 changes: 1 addition & 1 deletion demos/browser/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
},
"dependencies": {
"amazon-chime-sdk-js": "file:../..",
"aws-sdk": "^2.719.0",
"aws-sdk": "^2.725.0",
"bootstrap": "^4.3.1",
"compression": "^1.7.4",
"jquery": "^3.4.1",
Expand Down
6,922 changes: 3,467 additions & 3,455 deletions docs/assets/js/search.js
View file

Large diffs are not rendered by default.

67 changes: 55 additions & 12 deletions docs/classes/defaultbrowserbehavior.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,13 @@ <h3>Methods</h3>
<li class="tsd-kind-method tsd-parent-kind-class tsd-is-private"><a href="defaultbrowserbehavior.html#ispixel3" class="tsd-kind-icon">is<wbr>Pixel3</a></li>
<li class="tsd-kind-method tsd-parent-kind-class tsd-is-private"><a href="defaultbrowserbehavior.html#issafari" class="tsd-kind-icon">is<wbr>Safari</a></li>
<li class="tsd-kind-method tsd-parent-kind-class"><a href="defaultbrowserbehavior.html#issupported" class="tsd-kind-icon">is<wbr>Supported</a></li>
<li class="tsd-kind-method tsd-parent-kind-class tsd-is-private"><a href="defaultbrowserbehavior.html#isunifiedplansupported" class="tsd-kind-icon">is<wbr>Unified<wbr>Plan<wbr>Supported</a></li>
<li class="tsd-kind-method tsd-parent-kind-class"><a href="defaultbrowserbehavior.html#majorversion" class="tsd-kind-icon">major<wbr>Version</a></li>
<li class="tsd-kind-method tsd-parent-kind-class"><a href="defaultbrowserbehavior.html#name" class="tsd-kind-icon">name</a></li>
<li class="tsd-kind-method tsd-parent-kind-class"><a href="defaultbrowserbehavior.html#requiresbundlepolicy" class="tsd-kind-icon">requires<wbr>Bundle<wbr>Policy</a></li>
<li class="tsd-kind-method tsd-parent-kind-class"><a href="defaultbrowserbehavior.html#requirescheckforsdpconnectionattributes" class="tsd-kind-icon">requires<wbr>Check<wbr>For<wbr>Sdp<wbr>Connection<wbr>Attributes</a></li>
<li class="tsd-kind-method tsd-parent-kind-class"><a href="defaultbrowserbehavior.html#requiresicecandidategatheringtimeoutworkaround" class="tsd-kind-icon">requires<wbr>Ice<wbr>Candidate<wbr>Gathering<wbr>Timeout<wbr>Workaround</a></li>
<li class="tsd-kind-method tsd-parent-kind-class"><a href="defaultbrowserbehavior.html#requiresnoexactmediastreamconstraints" class="tsd-kind-icon">requires<wbr>NoExact<wbr>Media<wbr>Stream<wbr>Constraints</a></li>
<li class="tsd-kind-method tsd-parent-kind-class"><a href="defaultbrowserbehavior.html#requirespromisebasedwebrtcgetstats" class="tsd-kind-icon">requires<wbr>Promise<wbr>Based<wbr>WebRTCGet<wbr>Stats</a></li>
<li class="tsd-kind-method tsd-parent-kind-class"><a href="defaultbrowserbehavior.html#requiresresolutionalignment" class="tsd-kind-icon">requires<wbr>Resolution<wbr>Alignment</a></li>
<li class="tsd-kind-method tsd-parent-kind-class"><a href="defaultbrowserbehavior.html#requiressimulcastmunging" class="tsd-kind-icon">requires<wbr>Simulcast<wbr>Munging</a></li>
Expand Down Expand Up @@ -217,7 +219,7 @@ <h3>get<wbr>Display<wbr>Media<wbr>Audio<wbr>Capture<wbr>Support</h3>
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L120">src/browserbehavior/DefaultBrowserBehavior.ts:120</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L124">src/browserbehavior/DefaultBrowserBehavior.ts:124</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</span></h4>
Expand Down Expand Up @@ -270,7 +272,7 @@ <h3><span class="tsd-flag ts-flagPrivate">Private</span> is<wbr>Android</h3>
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L184">src/browserbehavior/DefaultBrowserBehavior.ts:184</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L188">src/browserbehavior/DefaultBrowserBehavior.ts:188</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</span></h4>
Expand All @@ -287,7 +289,7 @@ <h3><span class="tsd-flag ts-flagPrivate">Private</span> is<wbr>Chrome</h3>
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L176">src/browserbehavior/DefaultBrowserBehavior.ts:176</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L180">src/browserbehavior/DefaultBrowserBehavior.ts:180</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</span></h4>
Expand All @@ -304,7 +306,7 @@ <h3><span class="tsd-flag ts-flagPrivate">Private</span> is<wbr>Edge</h3>
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L180">src/browserbehavior/DefaultBrowserBehavior.ts:180</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L184">src/browserbehavior/DefaultBrowserBehavior.ts:184</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</span></h4>
Expand All @@ -321,7 +323,7 @@ <h3><span class="tsd-flag ts-flagPrivate">Private</span> is<wbr>Firefox</h3>
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L172">src/browserbehavior/DefaultBrowserBehavior.ts:172</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L176">src/browserbehavior/DefaultBrowserBehavior.ts:176</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</span></h4>
Expand All @@ -338,7 +340,7 @@ <h3><span class="tsd-flag ts-flagPrivate">Private</span> isIOSSafari</h3>
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L164">src/browserbehavior/DefaultBrowserBehavior.ts:164</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L168">src/browserbehavior/DefaultBrowserBehavior.ts:168</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</span></h4>
Expand All @@ -355,7 +357,7 @@ <h3><span class="tsd-flag ts-flagPrivate">Private</span> is<wbr>Pixel3</h3>
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L188">src/browserbehavior/DefaultBrowserBehavior.ts:188</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L192">src/browserbehavior/DefaultBrowserBehavior.ts:192</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</span></h4>
Expand All @@ -372,7 +374,7 @@ <h3><span class="tsd-flag ts-flagPrivate">Private</span> is<wbr>Safari</h3>
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L168">src/browserbehavior/DefaultBrowserBehavior.ts:168</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L172">src/browserbehavior/DefaultBrowserBehavior.ts:172</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</span></h4>
Expand All @@ -390,7 +392,24 @@ <h3>is<wbr>Supported</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/browserbehavior.html">BrowserBehavior</a>.<a href="../interfaces/browserbehavior.html#issupported">isSupported</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L131">src/browserbehavior/DefaultBrowserBehavior.ts:131</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L135">src/browserbehavior/DefaultBrowserBehavior.ts:135</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</span></h4>
</li>
</ul>
</section>
<section class="tsd-panel tsd-member tsd-kind-method tsd-parent-kind-class tsd-is-private">
<a name="isunifiedplansupported" class="tsd-anchor"></a>
<h3><span class="tsd-flag ts-flagPrivate">Private</span> is<wbr>Unified<wbr>Plan<wbr>Supported</h3>
<ul class="tsd-signatures tsd-kind-method tsd-parent-kind-class tsd-is-private">
<li class="tsd-signature tsd-kind-icon">is<wbr>Unified<wbr>Plan<wbr>Supported<span class="tsd-signature-symbol">(</span><span class="tsd-signature-symbol">)</span><span class="tsd-signature-symbol">: </span><span class="tsd-signature-type">boolean</span></li>
</ul>
<ul class="tsd-descriptions">
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L196">src/browserbehavior/DefaultBrowserBehavior.ts:196</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</span></h4>
Expand Down Expand Up @@ -487,6 +506,24 @@ <h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</
</li>
</ul>
</section>
<section class="tsd-panel tsd-member tsd-kind-method tsd-parent-kind-class">
<a name="requiresnoexactmediastreamconstraints" class="tsd-anchor"></a>
<h3>requires<wbr>NoExact<wbr>Media<wbr>Stream<wbr>Constraints</h3>
<ul class="tsd-signatures tsd-kind-method tsd-parent-kind-class">
<li class="tsd-signature tsd-kind-icon">requires<wbr>NoExact<wbr>Media<wbr>Stream<wbr>Constraints<span class="tsd-signature-symbol">(</span><span class="tsd-signature-symbol">)</span><span class="tsd-signature-symbol">: </span><span class="tsd-signature-type">boolean</span></li>
</ul>
<ul class="tsd-descriptions">
<li class="tsd-description">
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/browserbehavior.html">BrowserBehavior</a>.<a href="../interfaces/browserbehavior.html#requiresnoexactmediastreamconstraints">requiresNoExactMediaStreamConstraints</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L120">src/browserbehavior/DefaultBrowserBehavior.ts:120</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</span></h4>
</li>
</ul>
</section>
<section class="tsd-panel tsd-member tsd-kind-method tsd-parent-kind-class">
<a name="requirespromisebasedwebrtcgetstats" class="tsd-anchor"></a>
<h3>requires<wbr>Promise<wbr>Based<wbr>WebRTCGet<wbr>Stats</h3>
Expand Down Expand Up @@ -649,7 +686,7 @@ <h3>screen<wbr>Share<wbr>Unsupported</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/browserbehavior.html">BrowserBehavior</a>.<a href="../interfaces/browserbehavior.html#screenshareunsupported">screenShareUnsupported</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L124">src/browserbehavior/DefaultBrowserBehavior.ts:124</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L128">src/browserbehavior/DefaultBrowserBehavior.ts:128</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</span></h4>
Expand All @@ -667,7 +704,7 @@ <h3>support<wbr>String</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/browserbehavior.html">BrowserBehavior</a>.<a href="../interfaces/browserbehavior.html#supportstring">supportString</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L135">src/browserbehavior/DefaultBrowserBehavior.ts:135</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L139">src/browserbehavior/DefaultBrowserBehavior.ts:139</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">string</span></h4>
Expand All @@ -685,7 +722,7 @@ <h3>supported<wbr>Video<wbr>Codecs</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/browserbehavior.html">BrowserBehavior</a>.<a href="../interfaces/browserbehavior.html#supportedvideocodecs">supportedVideoCodecs</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L143">src/browserbehavior/DefaultBrowserBehavior.ts:143</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/master/src/browserbehavior/DefaultBrowserBehavior.ts#L147">src/browserbehavior/DefaultBrowserBehavior.ts:147</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">Promise</span><span class="tsd-signature-symbol">&lt;</span><span class="tsd-signature-type">string</span><span class="tsd-signature-symbol">[]</span><span class="tsd-signature-symbol">&gt;</span></h4>
Expand Down Expand Up @@ -935,6 +972,9 @@ <h3>safari</h3>
<li class=" tsd-kind-method tsd-parent-kind-class">
<a href="defaultbrowserbehavior.html#issupported" class="tsd-kind-icon">is<wbr>Supported</a>
</li>
<li class=" tsd-kind-method tsd-parent-kind-class tsd-is-private">
<a href="defaultbrowserbehavior.html#isunifiedplansupported" class="tsd-kind-icon">is<wbr>Unified<wbr>Plan<wbr>Supported</a>
</li>
<li class=" tsd-kind-method tsd-parent-kind-class">
<a href="defaultbrowserbehavior.html#majorversion" class="tsd-kind-icon">major<wbr>Version</a>
</li>
Expand All @@ -950,6 +990,9 @@ <h3>safari</h3>
<li class=" tsd-kind-method tsd-parent-kind-class">
<a href="defaultbrowserbehavior.html#requiresicecandidategatheringtimeoutworkaround" class="tsd-kind-icon">requires<wbr>Ice<wbr>Candidate<wbr>Gathering<wbr>Timeout<wbr>Workaround</a>
</li>
<li class=" tsd-kind-method tsd-parent-kind-class">
<a href="defaultbrowserbehavior.html#requiresnoexactmediastreamconstraints" class="tsd-kind-icon">requires<wbr>NoExact<wbr>Media<wbr>Stream<wbr>Constraints</a>
</li>
<li class=" tsd-kind-method tsd-parent-kind-class">
<a href="defaultbrowserbehavior.html#requirespromisebasedwebrtcgetstats" class="tsd-kind-icon">requires<wbr>Promise<wbr>Based<wbr>WebRTCGet<wbr>Stats</a>
</li>
Expand Down

0 comments on commit fe52357

Please sign in to comment.