This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
chore: update integ tests #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyen102
commented
Jul 3, 2023
|
|
||
| dotenv.config({ path: '.env' }); | ||
| import path from "path"; | ||
| dotenv.config({ path: path.resolve(__dirname, './.env') }); |
There was a problem hiding this comment.
This allows tests to read the environment file in correctly.
nguyen102
commented
Jul 3, 2023
|
|
||
| describe('MigrationUtils', () => { | ||
| describe('getFhirClient', () => { | ||
| test('client should be able to authenticate', async () => { | ||
| await expect(getFhirClient()).resolves.not.toThrowError(); | ||
| await expect(getFhirClient()).resolves.toBeDefined(); |
There was a problem hiding this comment.
not.toThrowError() wasn't working properly so I updated the code based on this SO
https://stackoverflow.com/questions/65793240/testing-for-an-error-not-being-thrown-by-an-async-function
nguyen102
commented
Jul 3, 2023
| }, | ||
| "dependencies": { | ||
| "axios": "0.25.0", | ||
| "axios": "0.26.0", |
There was a problem hiding this comment.
I was getting this error error: Error: Provided config url is not valid
It was fixed in version 0.26.
axios/axios#4407
nguyen102
force-pushed
the
thingut/migrate-tool-int-test-fixes
branch
from
38c5396
to
85c069e
Compare
nguyen102
commented
Jul 5, 2023
| @@ -3,7 +3,7 @@ | |||
| "rushVersion": "5.83.1", | |||
| "pnpmVersion": "7.13.0", | |||
| "nodeSupportedVersionRange": ">=16.13.0 <17.0.0 || >=18.14.0 <19.0.0", | |||
| "ensureConsistentVersions": true, | |||
| "ensureConsistentVersions": false, | |||
There was a problem hiding this comment.
Allows fwoa-tools to have a different package version of axios from the other projects in the repo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Checklist:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.