Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding sample automation for PR #121

Merged
merged 6 commits into from
Jul 20, 2021
Merged

Conversation

alan-churley
Copy link
Contributor

@alan-churley alan-churley commented Jul 20, 2021

Description of your changes

Proposal for automating tests for PRs

How to verify this change

Related issues, RFCs

#120

PR status

Is this ready for review?: NO
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alan-churley alan-churley changed the title Adding sample automation for PR feat: Adding sample automation for PR Jul 20, 2021
@github-actions
Copy link
Contributor

Coverage after merging feat/pr_automation into main

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Logger.ts100%100%100%100%
   helpers.ts100%100%100%100%
   index.ts100%100%100%100%
src/config
   ConfigService.ts100%100%100%100%
   EnvironmentVariablesService.ts100%100%100%100%
   index.ts100%100%100%100%
src/formatter
   LogFormatter.ts100%100%100%100%
   PowertoolLogFormatter.ts100%100%100%100%
   index.ts100%100%100%100%
src/log
   LogItem.ts100%100%100%100%
   index.ts100%100%100%100%

@github-actions
Copy link
Contributor

Coverage after merging feat/pr_automation into main

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Logger.ts100%100%100%100%
   helpers.ts100%100%100%100%
   index.ts100%100%100%100%
src/config
   ConfigService.ts100%100%100%100%
   EnvironmentVariablesService.ts100%100%100%100%
   index.ts100%100%100%100%
src/formatter
   LogFormatter.ts100%100%100%100%
   PowertoolLogFormatter.ts100%100%100%100%
   index.ts100%100%100%100%
src/log
   LogItem.ts100%100%100%100%
   index.ts100%100%100%100%

- uses: actions/checkout@v2
- name: Install packages
run: |
export NODE_ENV=dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider setting the environment variable like so

     runs-on: ubuntu-latest
     env:
          NODE_ENV: dev
     steps:
          ...

@github-actions
Copy link
Contributor

Coverage after merging feat/pr_automation into main

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Logger.ts100%100%100%100%
   helpers.ts100%100%100%100%
   index.ts100%100%100%100%
src/config
   ConfigService.ts100%100%100%100%
   EnvironmentVariablesService.ts100%100%100%100%
   index.ts100%100%100%100%
src/formatter
   LogFormatter.ts100%100%100%100%
   PowertoolLogFormatter.ts100%100%100%100%
   index.ts100%100%100%100%
src/log
   LogItem.ts100%100%100%100%
   index.ts100%100%100%100%

saragerion
saragerion previously approved these changes Jul 20, 2021
Copy link
Contributor

@saragerion saragerion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great!

.github/workflows/on-pull-request.yml Show resolved Hide resolved
@saragerion saragerion added this to Pull Requests - Work in progress in Pull Requests Jul 20, 2021
Pull Requests automation moved this from Pull Requests - Work in progress to Pull Requests - Review needed Jul 20, 2021
@github-actions
Copy link
Contributor

Coverage after merging feat/pr_automation into main

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
./packages/logger/src
   Logger.ts100%100%100%100%
   helpers.ts100%100%100%100%
   index.ts100%100%100%100%
./packages/logger/src/config
   ConfigService.ts100%100%100%100%
   EnvironmentVariablesService.ts100%100%100%100%
   index.ts100%100%100%100%
./packages/logger/src/formatter
   LogFormatter.ts100%100%100%100%
   PowertoolLogFormatter.ts100%100%100%100%
   index.ts100%100%100%100%
./packages/logger/src/log
   LogItem.ts100%100%100%100%
   index.ts100%100%100%100%

@github-actions
Copy link
Contributor

Coverage after merging feat/pr_automation into main

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
./packages/logger/src
   Logger.ts100%100%100%100%
   helpers.ts100%100%100%100%
   index.ts100%100%100%100%
./packages/logger/src/config
   ConfigService.ts100%100%100%100%
   EnvironmentVariablesService.ts100%100%100%100%
   index.ts100%100%100%100%
./packages/logger/src/formatter
   LogFormatter.ts100%100%100%100%
   PowertoolLogFormatter.ts100%100%100%100%
   index.ts100%100%100%100%
./packages/logger/src/log
   LogItem.ts100%100%100%100%
   index.ts100%100%100%100%

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

Copy link
Contributor

@saragerion saragerion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pull Requests automation moved this from Pull Requests - Review needed to Pull Requests - Approved and ready to be merged Jul 20, 2021
@alan-churley alan-churley merged commit 7bf63bb into main Jul 20, 2021
Pull Requests automation moved this from Pull Requests - Approved and ready to be merged to Pull Requests - Merged or Closed Jul 20, 2021
@alan-churley alan-churley deleted the feat/pr_automation branch July 20, 2021 13:34
@flochaz flochaz mentioned this pull request Dec 6, 2021
10 tasks
@heitorlessa heitorlessa added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
No open projects
Pull Requests
Pull Requests - Merged or Closed
Development

Successfully merging this pull request may close these issues.

None yet

4 participants