-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event-handler): add appsync batch invoke #1998
base: develop
Are you sure you want to change the base?
feat(event-handler): add appsync batch invoke #1998
Conversation
1ceecf7
to
ccdbbea
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1998 +/- ##
===========================================
- Coverage 96.38% 96.35% -0.03%
===========================================
Files 214 219 +5
Lines 10030 10334 +304
Branches 1846 1928 +82
===========================================
+ Hits 9667 9957 +290
- Misses 259 270 +11
- Partials 104 107 +3 ☔ View full report in Codecov by Sentry. |
ccdbbea
to
d0fe867
Compare
72dc94f
to
524d054
Compare
524d054
to
bc45703
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for the change, that's much better! Made one comment about favouring composition instead of multiple inheritance (it'll bite us!).
One super helpful change would be to update PR description with a sample UX, so that customers could easily spot what's coming, we could reuse in our docs, and release notes :-)
I'll do a proper review next week
efcb664
to
5668cba
Compare
Quality Gate passedIssues Measures |
can I have a quick update on this, please? |
Issue Number: #1303
Summary
Support Appsync batching mechanism for Lambda Resolvers
Changes
User experience
If batch processing is used for specific method, user can access AppSyncResolver events directly in their annotated method and do appropriate processing. Appsync resolver calls method for every event from the coming list of events:
Under the hood, Router:
batch_resolver
.type_name
andfield_name
and calls it for every event in the list. It passes the event itself to it as parameter argument. Optionally it pass user specified parameters if they are present - they are taken from the inside of the event itself. We pass user specified parameters to keep similar UX as with baseresolver
.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.