Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.9 support #626

Closed
wants to merge 2 commits into from
Closed

Add Python 3.9 support #626

wants to merge 2 commits into from

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Dec 10, 2020

Signed-off-by: Gábor Lipták gliptak@gmail.com

@andrew-glenn
Copy link
Contributor

@gliptak - Thanks for this PR! For housekeeping purposes, I'm flipping this to draft while you iterate on the Travis testing part. Mark it as ready once that's ironed out! 👍

@andrew-glenn andrew-glenn marked this pull request as draft December 12, 2020 16:08
@gliptak
Copy link
Contributor Author

gliptak commented Dec 12, 2020

mypy might not fully support ```3.9``

https://travis-ci.org/github/aws-quickstart/taskcat/jobs/749308055

taskcat/_cli_modules/upload.py:36: error: syntax error in type comment
Found 1 error in 1 file (checked 37 source files)

python/mypy#9761

@hauntsaninja
Copy link

You're using a pretty old version of mypy, if you switch to a recent version that error will go away :-)

@gliptak
Copy link
Contributor Author

gliptak commented Dec 14, 2020

@hauntsaninja same error even after moving to latest pre-commit

https://travis-ci.org/github/aws-quickstart/taskcat/jobs/749501718

@gliptak
Copy link
Contributor Author

gliptak commented Jan 25, 2021

@gliptak
Copy link
Contributor Author

gliptak commented Feb 12, 2021

mypy.....................................................................Failed
- hook id: mypy
- exit code: 2
taskcat/testing/_abstract_test.py:67: error: syntax error in type comment
taskcat/testing/_abstract_test.py:78: error: syntax error in type comment
Found 2 errors in 1 file (checked 44 source files)

Looks valid as per https://mypy.readthedocs.io/en/latest/generics.html

Signed-off-by: Gábor Lipták <gliptak@gmail.com>
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants